From: Ben Kaduk <kaduk@mit.edu>
Date: Mon, 3 Dec 2012 19:21:55 +0000 (-0500)
Subject: Access keys for the KfW ribbon interface
X-Git-Tag: kfw-4.0.1-beta1~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=49a26d8e941b074e607e26a457995c69e69a24e3;p=thirdparty%2Fkrb5.git

Access keys for the KfW ribbon interface

Improve accessibility by actually enabling access keys for ribbon
elements (tap alt and follow the onscreen hints for keys to press),
instead of just underlining a letter in the name of each element.

Supply an underlined letter in the text of each element, corresponding
to this access key, even if there is not a shortcut key bound to that
element.  While here, fix conflicting assignment to 'R' on the 'options'
tab (between "Renewable Until" and "Automatic Ticket Renewal") by
making "Automatic Ticket Renewal" use 'T'.  Microsoft's UI recommendations
seem to say that access keys should be easy to locate when searching
through the menu, and thus using the first letter of the first or
second word is advisable.

The Ribbon XML Reference seems to indicate that these elements should
be "keytip" elements, but MSVS creates "keys" elements, which seem
to work, whereas "keytip" does not.  Apparently 'F' is standard for
the application button menu (which contains exit).  Access keys work
somewhat poorly for us in this menu, as they appear on top of the text
of the menu items, since we have no icons here.

(cherry picked from commit eacf40bdc52ae3c43dad58429086c39a8ce4d395)

ticket: 7441
status: resolved
---

diff --git a/src/windows/leash/res/ribbon1.mfcribbon-ms b/src/windows/leash/res/ribbon1.mfcribbon-ms
index 7d20def4a8..e8b1bd99c1 100644
--- a/src/windows/leash/res/ribbon1.mfcribbon-ms
+++ b/src/windows/leash/res/ribbon1.mfcribbon-ms
@@ -16,6 +16,7 @@
         <NAME>ID_BUTTON2</NAME>
         <VALUE>32813</VALUE>
       </ID>
+      <KEYS>f</KEYS>
       <PALETTE_TOP>FALSE</PALETTE_TOP>
       <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
       <INDEX_SMALL>-1</INDEX_SMALL>
@@ -39,6 +40,7 @@
             <VALUE>32784</VALUE>
           </ID>
           <TEXT>&amp;Help</TEXT>
+          <KEYS>h</KEYS>
           <PALETTE_TOP>FALSE</PALETTE_TOP>
           <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
           <INDEX_SMALL>-1</INDEX_SMALL>
@@ -53,6 +55,7 @@
             <VALUE>57664</VALUE>
           </ID>
           <TEXT>&amp;About</TEXT>
+          <KEYS>a</KEYS>
           <PALETTE_TOP>FALSE</PALETTE_TOP>
           <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
           <INDEX_SMALL>-1</INDEX_SMALL>
@@ -67,6 +70,7 @@
             <VALUE>57665</VALUE>
           </ID>
           <TEXT>E&amp;xit</TEXT>
+          <KEYS>x</KEYS>
           <PALETTE_TOP>FALSE</PALETTE_TOP>
           <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
           <INDEX_SMALL>-1</INDEX_SMALL>
@@ -85,6 +89,7 @@
       <CATEGORY>
         <ELEMENT_NAME>Category</ELEMENT_NAME>
         <NAME>Home</NAME>
+        <KEYS>h</KEYS>
         <IMAGE_SMALL>
           <ID>
             <NAME>IDB_HOMESMALL</NAME>
@@ -111,6 +116,7 @@
                   <VALUE>32807</VALUE>
                 </ID>
                 <TEXT>Get &amp;Ticket</TEXT>
+                <KEYS>t</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>TRUE</ALWAYS_LARGE>
                 <INDEX_SMALL>2</INDEX_SMALL>
@@ -125,6 +131,7 @@
                   <VALUE>32776</VALUE>
                 </ID>
                 <TEXT>&amp;Renew Ticket</TEXT>
+                <KEYS>r</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>TRUE</ALWAYS_LARGE>
                 <INDEX_SMALL>3</INDEX_SMALL>
@@ -139,6 +146,7 @@
                   <VALUE>32777</VALUE>
                 </ID>
                 <TEXT>&amp;Destroy Ticket</TEXT>
+                <KEYS>d</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>TRUE</ALWAYS_LARGE>
                 <INDEX_SMALL>1</INDEX_SMALL>
@@ -152,7 +160,8 @@
                   <NAME>ID_MAKE_DEFAULT</NAME>
                   <VALUE>32835</VALUE>
                 </ID>
-                <TEXT>Make Default</TEXT>
+                <TEXT>&amp;Make Default</TEXT>
+                <KEYS>m</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>TRUE</ALWAYS_LARGE>
                 <INDEX_SMALL>6</INDEX_SMALL>
@@ -174,7 +183,8 @@
                   <NAME>ID_CHANGE_PASSWORD</NAME>
                   <VALUE>32779</VALUE>
                 </ID>
-                <TEXT>Change Password</TEXT>
+                <TEXT>Change &amp;Password</TEXT>
+                <KEYS>p</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
                 <INDEX_SMALL>5</INDEX_SMALL>
@@ -189,6 +199,7 @@
       <CATEGORY>
         <ELEMENT_NAME>Category</ELEMENT_NAME>
         <NAME>Options</NAME>
+        <KEYS>o</KEYS>
         <PANELS>
           <PANEL>
             <ELEMENT_NAME>Panel</ELEMENT_NAME>
@@ -204,6 +215,7 @@
                   <VALUE>32810</VALUE>
                 </ID>
                 <TEXT>&amp;Issued</TEXT>
+                <KEYS>i</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
                 <INDEX_SMALL>-1</INDEX_SMALL>
@@ -217,6 +229,7 @@
                   <VALUE>32811</VALUE>
                 </ID>
                 <TEXT>&amp;Renewable Until</TEXT>
+                <KEYS>r</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
                 <INDEX_SMALL>-1</INDEX_SMALL>
@@ -230,6 +243,7 @@
                   <VALUE>32828</VALUE>
                 </ID>
                 <TEXT>&amp;Valid Until</TEXT>
+                <KEYS>v</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
                 <INDEX_SMALL>-1</INDEX_SMALL>
@@ -243,6 +257,7 @@
                   <VALUE>32826</VALUE>
                 </ID>
                 <TEXT>&amp;Encryption Type</TEXT>
+                <KEYS>e</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
                 <INDEX_SMALL>-1</INDEX_SMALL>
@@ -256,6 +271,7 @@
                   <VALUE>32812</VALUE>
                 </ID>
                 <TEXT>&amp;Flags</TEXT>
+                <KEYS>f</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
                 <INDEX_SMALL>-1</INDEX_SMALL>
@@ -277,7 +293,8 @@
                   <NAME>ID_AUTO_RENEW</NAME>
                   <VALUE>32808</VALUE>
                 </ID>
-                <TEXT>Automatic Ticket &amp;Renewal</TEXT>
+                <TEXT>Automatic &amp;Ticket Renewal</TEXT>
+                <KEYS>t</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
                 <INDEX_SMALL>-1</INDEX_SMALL>
@@ -291,6 +308,7 @@
                   <VALUE>32798</VALUE>
                 </ID>
                 <TEXT>Expiration &amp;Alarm</TEXT>
+                <KEYS>a</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
                 <INDEX_SMALL>-1</INDEX_SMALL>
@@ -304,6 +322,7 @@
                   <VALUE>32785</VALUE>
                 </ID>
                 <TEXT>&amp;Destroy Tickets on Exit</TEXT>
+                <KEYS>d</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
                 <INDEX_SMALL>-1</INDEX_SMALL>
@@ -317,6 +336,7 @@
                   <VALUE>32787</VALUE>
                 </ID>
                 <TEXT>Allow &amp;Mixed Case Realm Name</TEXT>
+                <KEYS>m</KEYS>
                 <PALETTE_TOP>FALSE</PALETTE_TOP>
                 <ALWAYS_LARGE>FALSE</ALWAYS_LARGE>
                 <INDEX_SMALL>-1</INDEX_SMALL>