From: Volker Lendecke <vl@samba.org>
Date: Fri, 27 May 2022 16:38:34 +0000 (+0200)
Subject: lsa_server4: Simplify get_tdo() with dom_sid_str_buf()
X-Git-Tag: talloc-2.3.4~41
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=49b3bbdead787adf99e5187ede0fc0384af62311;p=thirdparty%2Fsamba.git

lsa_server4: Simplify get_tdo() with dom_sid_str_buf()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/rpc_server/lsa/dcesrv_lsa.c b/source4/rpc_server/lsa/dcesrv_lsa.c
index 4101d6ddd34..8861cf95af8 100644
--- a/source4/rpc_server/lsa/dcesrv_lsa.c
+++ b/source4/rpc_server/lsa/dcesrv_lsa.c
@@ -1673,7 +1673,6 @@ static NTSTATUS get_tdo(struct ldb_context *sam, TALLOC_CTX *mem_ctx,
 	};
 	char *dns = NULL;
 	char *nbn = NULL;
-	char *sidstr = NULL;
 	char *filter;
 	int ret;
 
@@ -1712,10 +1711,8 @@ static NTSTATUS get_tdo(struct ldb_context *sam, TALLOC_CTX *mem_ctx,
 		}
 	}
 	if (sid) {
-		sidstr = dom_sid_string(mem_ctx, sid);
-		if (!sidstr) {
-			return NT_STATUS_INVALID_PARAMETER;
-		}
+		struct dom_sid_buf buf;
+		char *sidstr = dom_sid_str_buf(sid, &buf);
 		filter = talloc_asprintf_append(filter,
 						"(securityIdentifier=%s)",
 						sidstr);