From: Dan Carpenter Date: Tue, 15 Jul 2025 23:01:30 +0000 (-0500) Subject: net/mlx5: Fix an IS_ERR() vs NULL bug in esw_qos_move_node() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=49be1e245ea3e3515c5989ce1af215d8500dec85;p=thirdparty%2Flinux.git net/mlx5: Fix an IS_ERR() vs NULL bug in esw_qos_move_node() The __esw_qos_alloc_node() function returns NULL on error. It doesn't return error pointers. Update the error checking to match. Fixes: 96619c485fa6 ("net/mlx5: Add support for setting tc-bw on nodes") Signed-off-by: Dan Carpenter Reviewed-by: Tariq Toukan Link: https://patch.msgid.link/0ce4ec2a-2b5d-4652-9638-e715a99902a7@sabinyo.mountain Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c index e1cef8dd3b4dd..91d863c8c152a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c @@ -1405,9 +1405,10 @@ esw_qos_move_node(struct mlx5_esw_sched_node *curr_node) new_node = __esw_qos_alloc_node(curr_node->esw, curr_node->ix, curr_node->type, NULL); - if (!IS_ERR(new_node)) - esw_qos_nodes_set_parent(&curr_node->children, new_node); + if (!new_node) + return ERR_PTR(-ENOMEM); + esw_qos_nodes_set_parent(&curr_node->children, new_node); return new_node; }