From: cptpcrd <cptpcrd.git@gmail.com>
Date: Mon, 31 Jul 2023 23:33:33 +0000 (-0400)
Subject: dbus-sysdeps-unix: Check socklen_t is unsigned when getting group list
X-Git-Tag: dbus-1.15.8~33^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=49dd4aba42280c438b1207963f7071bfd7707775;p=thirdparty%2Fdbus.git

dbus-sysdeps-unix: Check socklen_t is unsigned when getting group list

After the change to handle an empty list properly, the function now
assumes that is true.
---

diff --git a/dbus/dbus-sysdeps-unix.c b/dbus/dbus-sysdeps-unix.c
index 486c4e219..6962b0771 100644
--- a/dbus/dbus-sysdeps-unix.c
+++ b/dbus/dbus-sysdeps-unix.c
@@ -1956,6 +1956,8 @@ add_groups_to_credentials (int              client_fd,
 {
 #if defined(__linux__) && defined(SO_PEERGROUPS)
   _DBUS_STATIC_ASSERT (sizeof (gid_t) <= sizeof (dbus_gid_t));
+  /* This function assumes socklen_t is unsigned, which is true on Linux */
+  _DBUS_STATIC_ASSERT (((socklen_t) -1) > 0);
   gid_t *buf = NULL;
   socklen_t len = 1024;
   dbus_bool_t oom = FALSE;