From: Marek Schimara <Marek.Schimara@bull.net>
Date: Wed, 15 Jun 2016 13:53:52 +0000 (+0200)
Subject: src/rrd_modify.c: fix Coverity CID#32405 Logically dead code
X-Git-Tag: v1.7.0~42^2~45
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=49f4785e0fb3dd731983d0b958b5044f9d340149;p=thirdparty%2Frrdtool-1.x.git

src/rrd_modify.c: fix Coverity CID#32405 Logically dead code

        CWE-561 / https://cwe.mitre.org/data/definitions/561.html
---

diff --git a/src/rrd_modify.c b/src/rrd_modify.c
index a6a5033f..369d7a1f 100644
--- a/src/rrd_modify.c
+++ b/src/rrd_modify.c
@@ -1024,11 +1024,6 @@ static void prepare_CDPs(const rrd_t *in, rrd_t *out,
     candidate_t *chosen_candidate = NULL;
     candidate_extra_t junk;
     
-    if (candidates) {
-	free(candidates);
-	candidates = NULL;
-    }
-
     candidates = find_candidate_rras(in, rra_def, &candidates_cnt, junk, select_for_modify);
 
     if (candidates != NULL) {