From: Eric Bollengier <eric@baculasystems.com>
Date: Tue, 25 Oct 2022 07:46:52 +0000 (+0200)
Subject: regress: Adapt immutable and read-only test
X-Git-Tag: Beta-15.0.0~388
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4a08280661d68fe5ec8696dc16ba8f08d0b548a5;p=thirdparty%2Fbacula.git

regress: Adapt immutable and read-only test
---

diff --git a/regress/scripts/functions.pm b/regress/scripts/functions.pm
index 8ced43ff1..4849d39be 100644
--- a/regress/scripts/functions.pm
+++ b/regress/scripts/functions.pm
@@ -52,7 +52,7 @@ our @EXPORT = qw(update_some_files create_many_files check_multiple_copies
                   check_openfile check_cloud_hash check_bscan add_log_message compare_backup_content
                   check_tls_traces println add_virtual_changer check_events check_events_json
                   create_many_hardlinks check_dot_status parse_fuse_trace generate_random_seek
-                  check_storage_selection check_json get_perm
+                  check_storage_selection check_json get_perm check_protect
 );
 
 
@@ -2585,4 +2585,40 @@ sub get_perm
     my $mode = (stat($file))[2];
     printf "%04o\n", $mode & 07777;
 }
+
+# Parse the output of llist volume to check the protection parameters
+sub check_protect
+{
+    my ($file, $name, $status, $protect, $useprotect) = @_;
+    open(FP, $file) or die "Unable to open $file. $!";
+    my $found=0;
+    while (my $line = <FP>) {
+        if ($line =~ /volumename: (\S+)/i) {
+            if ($name eq $1) {
+                $found=1;
+            } else {
+                $found=0;
+            }
+        }
+        if ($found) {
+            if ($line =~ /volstatus: +(\S+)/i) {
+                if (defined $status && $status ne $1) {
+                    print "ERROR: volstatus for $name $status != $1 in $file\n";
+                    exit 1;
+                }
+            } elsif ($line =~ /useprotect: +(\S+)/i) {
+                if (defined $useprotect && $useprotect != $1) {
+                    print "ERROR: useprotect for $name $protect != $1 in $file\n";
+                    exit 1;
+                }
+            } elsif ($line =~ /protect: +(\S+)/i) {
+                if (defined $protect && $protect != $1) {
+                    print "ERROR: protect for $name $protect != $1 in $file $line\n";
+                    exit 1;
+                }
+            }
+        }
+    }
+    close(FP);
+}
 1;
diff --git a/regress/tests/read-only-volume-test b/regress/tests/read-only-volume-test
new file mode 100755
index 000000000..0f3d194d2
--- /dev/null
+++ b/regress/tests/read-only-volume-test
@@ -0,0 +1,157 @@
+#!/usr/bin/env bash
+#
+# Copyright (C) 2000-2021 Kern Sibbald
+# Copyright (C) 2021-2022 Bacula Systems SA
+# License: BSD 2-Clause; see file LICENSE-FOSS
+#
+# Run a simple backup of the Bacula build directory
+#   then restore it. Use the Set Volume Read Only storage
+#   daemon directive.
+#
+TestName="read-only-volume-test"
+JobName=backup
+. scripts/functions
+
+scripts/cleanup
+scripts/copy-confs
+
+#
+# Zap out any schedule in default conf file so that
+#  it doesn't start during our test
+#
+outf="$tmp/sed_tmp"
+echo "s%  Schedule =%# Schedule =%g" >${outf}
+cp $scripts/bacula-dir.conf $tmp/1
+sed -f ${outf} $tmp/1 >$scripts/bacula-dir.conf
+
+$bperl -e "add_attribute('$conf/bacula-sd.conf', 'SetVolumeReadOnly', 'yes', 'Device')"
+$bperl -e "add_attribute('$conf/bacula-dir.conf', 'MaximumVolumeBytes', '50MB', 'Pool')"
+$bperl -e "add_attribute('$conf/bacula-dir.conf', 'MaximumVolumeJobs', '1', 'Pool')"
+
+cat <<EOF >> $conf/bacula-dir.conf
+Job {
+  Name = adm-update-protected
+  Type = Admin
+  Runscript {
+   Console = "update volumeprotect"
+   RunsOnClient = no
+   RunsWhen = Before
+  }
+  JobDefs = DefaultJob
+}
+EOF
+
+change_jobname BackupClient1 $JobName
+start_test
+
+cat <<END_OF_DATA >$tmp/bconcmds
+@output /dev/null
+messages
+@$out $tmp/log1.out
+setdebug level=50 tags=volume trace=1 storage=File1
+setdebug level=50 tags=volume trace=1 dir
+run job=$JobName yes
+wait
+messages
+@exec "stat $tmp/Vol-0001"
+@output $tmp/log4.out
+@# info: List volumes after the first job
+llist volume=Vol-0001
+@# 
+@# now do a restore
+@#
+@$out $tmp/log2.out  
+restore where=$tmp/bacula-restores select all done
+yes
+wait
+messages
+purge volume=Vol-0001 yes
+update volume=Vol-0002 volstatus=Used
+run job=$JobName yes
+wait
+messages
+run job=$JobName level=Full yes
+wait
+messages
+run job=$JobName level=Full storage=File2 yes
+wait
+messages
+@output $tmp/log3.out
+@# info: List volumes at the end
+@exec "stat $tmp/Vol-0001"
+@exec "stat $tmp/Vol-0002"
+llist volume
+@$out $tmp/log1.out
+setbandwidth limit=1000 client
+run job=$JobName level=Full storage=File2 yes
+@sleep 5
+.status dir running
+messages
+update volumeprotect
+setbandwidth limit=10000000 client
+wait
+messages
+@output $tmp/vol1.out
+llist volume
+@$out $tmp/log5.out
+run job=adm-update-protected yes
+wait
+messages
+@output $tmp/vol5.out
+llist volume=Vol-0014
+quit
+END_OF_DATA
+
+run_bacula
+check_for_zombie_jobs storage=File1
+stop_bacula
+
+$bperl -e 'my @r = stat("$tmp/Vol-0001"); exit (($r[2] & 07777 & 0400) && $r[8] > $r[9] && $r[7] > 1000*1000*49);'
+if [ $? -ne 1 ]; then
+    print_debug "ERROR: problem with volume attribute"
+    stat $tmp/Vol-0001
+    estat=1
+fi
+
+$bperl -e 'check_protect("$tmp/log4.out", "Vol-0001", "Used", 1, 1)'
+if [ $? != 0 ]; then
+    estat=1
+fi
+
+$bperl -e 'check_protect("$tmp/log4.out", "Vol-0002", "Used", 1, 1)'
+if [ $? != 0 ]; then
+    estat=1
+fi
+
+$bperl -e 'check_protect("$tmp/log4.out", "Vol-0004", "Used", 1, 1)'
+if [ $? != 0 ]; then
+    estat=1
+fi
+
+$bperl -e 'check_protect("$tmp/log4.out", "Vol-0003", "Used", undef, 1)'
+if [ $? != 0 ]; then
+    estat=1
+fi
+
+$bperl -e 'check_protect("$tmp/log4.out", "Vol-0005", "Used", undef, 1)'
+if [ $? != 0 ]; then
+    estat=1
+fi
+
+$bperl -e 'check_protect("$tmp/log3.out", "Vol-0001", "Recycle")'
+if [ $? != 0 ]; then
+    estat=1
+fi
+
+$bperl -e 'check_protect("$tmp/log5.out", "Vol-0014", "Used", 1, 1)'
+if [ $? != 0 ]; then
+    estat=1
+fi
+
+$bperl -e 'check_protect("$tmp/log1.out", "Vol-0014", "Used", 0, 1)'
+if [ $? != 0 ]; then
+    estat=1
+fi
+check_two_logs
+check_restore_diff
+end_test
diff --git a/regress/tests/volume-immutable-test b/regress/tests/volume-immutable-test
index 10ee8bc0e..c25142ed4 100755
--- a/regress/tests/volume-immutable-test
+++ b/regress/tests/volume-immutable-test
@@ -85,11 +85,20 @@ messages
 run job=$JobName yes
 wait
 messages
+@output $tmp/vol1.out
+llist volumes
 quit
 END_OF_DATA
 
 run_bconsole
 
+$bperl -e 'check_protect("$tmp/vol1.out", "Vol-0001", "Full", 1, 1)'
+if [ $? != 0 ]; then
+    grep -iE 'info|volumename|protect|status' $tmp/vol1.out
+    estat=1
+fi
+
+
 backup_res=`cat $tmp/log1.out| grep 'Termination:' | grep 'Backup OK' | wc -l`
 if [ ${backup_res} -ne 1 ]; then
    estat=1
@@ -116,16 +125,46 @@ fi
 
 cat <<END_OF_DATA >$tmp/bconcmds
 @$out $tmp/log2.out
+label volume=Vol-0010 slot=0 pool=Default storage=File1 drive=0
+update volume=Vol-0010 volstatus=Used
+@output $tmp/vol22.out
+llist volume=Vol-0010
+@$out $tmp/log2.out
+@exec "grep -iE 'info|volumename|protect|status' $tmp/vol22.out"
+@#################################"
 purge volume=Vol-0001
+update volume=Vol-0001 actiononpurge=truncate
+truncate volume=Vol-0001 storage=File1 yes
+@output $tmp/vol2.out
+llist volume=Vol-0001
+@$out $tmp/log2.out
 relabel oldvolume=Vol-0001 volume=RelabeledVol-0001 slot=0 pool=Default storage=File1 drive=0
 @$out $tmp/log3.out
-@sleep 20
+@sleep 15
 relabel oldvolume=Vol-0001 volume=RelabeledVol-0001 slot=0 pool=Default storage=File1 drive=0
+@output $tmp/vol3.out
+llist volume
+@$out $tmp/log3.out
+update volumeprotect
+@output $tmp/vol4.out
+llist volume
 quit
 END_OF_DATA
 
 run_bconsole
 
+$bperl -e 'check_protect("$tmp/vol2.out", "Vol-0001", "Purged", 1, 1)'
+if [ $? != 0 ]; then
+    grep -iE 'info|volumename|protect|status' $tmp/vol2.out
+    estat=1
+fi
+
+$bperl -e 'check_protect("$tmp/vol3.out", "RelabeledVol-0001", "Append", 0, 1)'
+if [ $? != 0 ]; then
+    grep -iE 'info|volumename|protect|status' $tmp/vol3.out
+    estat=1
+fi
+
 # Check if volume has not been relabeled before expiration time
 label_res=`cat $tmp/log2.out| grep "Cannot open Volume Vol-0001 for writing/truncating, because Minimum Volume Protection Time hasn't expired yet" | wc -l`
 if [ ${label_res} -ne 1 ]; then