From: mkanat%bugzilla.org <>
Date: Thu, 26 Jun 2008 06:00:05 +0000 (+0000)
Subject: Bug 440609 – Implement Bugzilla::Bug->check for use instead of ValidateBugID and... 
X-Git-Tag: bugzilla-3.3.1~295
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4a0e946fb30212c232c6651a47e057d6cc602a1d;p=thirdparty%2Fbugzilla.git

Bug 440609 – Implement Bugzilla::Bug->check for use instead of ValidateBugID and use it in one file
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index ec603e2b2a..2335d0caa6 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -272,6 +272,15 @@ sub new {
     return $self;
 }
 
+sub check {
+    my $class = shift;
+    # XXX At some point we will eliminate ValidateBugID and make this
+    #     method more efficient.
+    ValidateBugID(@_);
+    my $self = $class->new(@_);
+    return $self;
+}
+
 # Docs for create() (there's no POD in this file yet, but we very
 # much need this documented right now):
 #
diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm
index 9463bce731..dd866a67bd 100755
--- a/Bugzilla/WebService/Bug.pm
+++ b/Bugzilla/WebService/Bug.pm
@@ -75,8 +75,7 @@ sub get {
 
     my @return;
     foreach my $bug_id (@$ids) {
-        ValidateBugID($bug_id);
-        my $bug = new Bugzilla::Bug($bug_id);
+        my $bug = Bugzilla::Bug->check($bug_id);
 
         # Timetracking fields are deleted if the user doesn't belong to
         # the corresponding group.
@@ -247,14 +246,12 @@ sub add_comment {
     
     # Check parameters
     defined $params->{id} 
-        || ThrowCodeError('param_required', { param => 'id' });
-    ValidateBugID($params->{id});
-    
+        || ThrowCodeError('param_required', { param => 'id' }); 
     my $comment = $params->{comment}; 
     defined $comment
         || ThrowCodeError('param_required', { param => 'comment' });
     
-    my $bug = new Bugzilla::Bug($params->{id});
+    my $bug = Bugzilla::Bug->check($params->{id});
     
     Bugzilla->user->can_edit_product($bug->product_id)
         || ThrowUserError("product_edit_denied", {product => $bug->product});