From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Fri, 8 Nov 2019 14:48:27 +0000 (-0500)
Subject: Work around setuptools issue #1902
X-Git-Tag: rel_1_4_0b1~635
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4a2dd4902a1168234f14bdd0634728086d53c406;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Work around setuptools issue #1902

Added a workaround for a setuptools-related failure that has been observed
as occurring on Windows installations, where setuptools is not correctly
reporting a build error when the MSVC build dependencies are not installed
and therefore not allowing graceful degradation into non C extensions
builds.

Setuptools issue https://github.com/pypa/setuptools/issues/1902

Fixes: #4967
Change-Id: I5e21e7e78cb6d927b18afce64cacf8643b98354e
---

diff --git a/doc/build/changelog/unreleased_13/4967.rst b/doc/build/changelog/unreleased_13/4967.rst
new file mode 100644
index 0000000000..341c572683
--- /dev/null
+++ b/doc/build/changelog/unreleased_13/4967.rst
@@ -0,0 +1,9 @@
+.. change::
+    :tags: bug, installation, windows
+    :tickets: 4967
+
+    Added a workaround for a setuptools-related failure that has been observed
+    as occurring on Windows installations, where setuptools is not correctly
+    reporting a build error when the MSVC build dependencies are not installed
+    and therefore not allowing graceful degradation into non C extensions
+    builds.
diff --git a/setup.py b/setup.py
index 560d76fca2..a5a2af248d 100644
--- a/setup.py
+++ b/setup.py
@@ -38,7 +38,8 @@ ext_errors = (CCompilerError, DistutilsExecError, DistutilsPlatformError)
 if sys.platform == "win32":
     # 2.6's distutils.msvc9compiler can raise an IOError when failing to
     # find the compiler
-    ext_errors += (IOError,)
+    # for TypeError, see https://github.com/pypa/setuptools/issues/1902
+    ext_errors += (IOError, TypeError)
 
 
 class BuildFailed(Exception):