From: Tim Hartwick Date: Wed, 21 Sep 2016 22:50:15 +0000 (-0700) Subject: adding an optional boolean to remove ios-blue styling for phone numbers and addresses X-Git-Tag: v2.3.0~7^2~33^2~2^2~2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4a5ab12e15c364cc80ffe19a40c6099b7812df7a;p=thirdparty%2Ffoundation%2Ffoundation-emails.git adding an optional boolean to remove ios-blue styling for phone numbers and addresses --- diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md deleted file mode 100644 index b352cf74..00000000 --- a/CONTRIBUTING.md +++ /dev/null @@ -1,46 +0,0 @@ -# Contributing to Foundation - -ZURB loves its community! We always want to hear from our users, whether they're reporting bugs, suggesting new features, or even adding them themselves. - -## Reporting Bugs - -[Open a new issue](https://github.com/zurb/foundation-emails/issues/new) to report a problem you're having with Foundation for Apps. When writing your issue, keep these things in mind: - -- **Be descriptive.** If you can, upload a screenshot of problem you're having, or copy and paste any JavaScript or command line errors you encounter. Being detailed will help us hone in on the problem faster. -- **Post your code.** It's very helpful to see any HTML, Sass, or JavaScript you've written that you think may be causing the problem. In some cases, we might be able to fix your problem just by fixing your code. -- **Help us recreate it.** If your problem is complex, tell us the steps needed to recreate the issue. Sometimes we need to see the problem for ourselves, in our own testing environment, so we can more easily debug it. - -## Editing the Documentation - -The documentation is compiled by a tool called [Supercollider](https://github.com/gakimball/supercollider). Each page is compiled from 1–2 sources: - -- A Markdown file under `docs/pages/`. -- If it's a Sass component, the relevant Sass file inside `scss/` is scanned for special [SassDoc](http://sassdoc.com/) comments. - -Each page is rendered in one big [Handlebars template](https://github.com/zurb/foundation-docs/blob/master/templates/component.html) that takes in all of the above data. - -Much of the guts of the documentation are stored in an external codebase called [foundation-docs](https://github.com/zurb/foundation-docs). This is code that's shared between the documentation for all three Foundation frameworks, including: - -- CSS specific to the documentation -- The Handlebars template used to build pages -- A series of Handlebars helpers for the template -- A custom Markdown parser used when parsing pages -- A script that generates the search results for documentation pages - -To hack on this repo locally, clone the foundation-docs repo into a folder adjacent to this repo's folder on your machine. Then run `npm link ../foundation-docs` to wire the two together. - -## Submitting Pull Requests - -If you think you can solve a problem yourself, or want to implement a new feature, go for it! Follow these guidelines to make the most killer PR ever. - -- **Target the right branch.** So we can properly follow [semantic versioning](http://semver.org/), be sure to develop your pull request in the right branch: - - Ink 1.0 changes: `v1.0` - - Foundation for Emails 2.0+ bug fixes: `develop` - - New features should be pointed to: `v2.2` -- **Test, test, and test.** The Foundation frameworks are used by thousands and thousands of designers and developers, so making sure your changes work in every email client is important! Please test bug fixes or new features in Litmus, or another email testing service. - -## Help Wanted - -Want something to work on? Let us guide you in the right direction. - -- Browse the [Help Wanted](https://github.com/zurb/foundation-emails/labels/help%20wanted) issue to see bugs or features we've asked for the community's help on. Feel free to implement them yourself as a pull request! diff --git a/scss/components/_typography.scss b/scss/components/_typography.scss index 0e0d63a7..4d94e6da 100755 --- a/scss/components/_typography.scss +++ b/scss/components/_typography.scss @@ -150,6 +150,10 @@ $anchor-color-active: $anchor-color-hover !default; /// @type Number $stat-font-size: 40px !default; +/// Removing the iOS telephone and address styling +/// @type Boolean +$remove-ios-blue: true !default; + body, table.body, h1, @@ -337,3 +341,18 @@ span.preheader { opacity: 0; overflow: hidden; } + +// Removing the iOS colors put in for telephone and addresses +@if $remove-ios-blue { + // Wrapping in a media only screen to have inline-css respect the styling + @media only screen { + a[x-apple-data-detectors] { + color: inherit !important; + text-decoration: none !important; + font-size: inherit !important; + font-family: inherit !important; + font-weight: inherit !important; + line-height: inherit !important; + } + } +} diff --git a/scss/settings/_settings.scss b/scss/settings/_settings.scss index 57c3d0f6..3fd5f2fc 100644 --- a/scss/settings/_settings.scss +++ b/scss/settings/_settings.scss @@ -90,6 +90,7 @@ $anchor-color-visited: $anchor-color; $anchor-color-hover: darken($primary-color, 10%); $anchor-color-active: $anchor-color-hover; $stat-font-size: 40px; +$remove-ios-blue: true; // 5. Button // --------- diff --git a/test/visual/pages/anchor.html b/test/visual/pages/anchor.html new file mode 100644 index 00000000..53130544 --- /dev/null +++ b/test/visual/pages/anchor.html @@ -0,0 +1,8 @@ + + + +

Testing to see if nasty phone and iOS links can be removed.

+

Lorem ipsum dolor sit amet, consectetur adipisicing elit. Rerum voluptates placeat laudantium, nihil minus commodi incidunt 513-555-5555 magni, accusamus vitae nemo? Sit, minima. Dolorem nisi quaerat voluptatum nobis, numquam saepe hic. 123 locust st santa cruz, ca 95060

+ + + \ No newline at end of file diff --git a/test/visual/pages/button-inky.html b/test/visual/pages/button-inky.html index 650e01dc..98ed9ac6 100644 --- a/test/visual/pages/button-inky.html +++ b/test/visual/pages/button-inky.html @@ -105,4 +105,14 @@ + + + + + + + + + + diff --git a/test/visual/pages/inliner-bugs.html b/test/visual/pages/inliner-bugs.html index f43c5332..f7ff3be2 100644 --- a/test/visual/pages/inliner-bugs.html +++ b/test/visual/pages/inliner-bugs.html @@ -1,4 +1,4 @@ - + \ No newline at end of file