From: Julian Seward <jseward@acm.org>
Date: Sat, 31 Jan 2009 23:03:08 +0000 (+0000)
Subject: Merge r9094:
X-Git-Tag: svn/VALGRIND_3_4_1~34
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4a63e815bdc954931b3caa8ff56e7725947f12fd;p=thirdparty%2Fvalgrind.git

Merge r9094:
   Move an assertion (pertaining to showing initial segments to the
   tools) to the correct place, and add a big comment explaining why
   this is necessary.



git-svn-id: svn://svn.valgrind.org/valgrind/branches/VALGRIND_3_4_BRANCH@9095
---

diff --git a/coregrind/m_main.c b/coregrind/m_main.c
index 7cf141d0f5..c8f015ef6e 100644
--- a/coregrind/m_main.c
+++ b/coregrind/m_main.c
@@ -1870,8 +1870,29 @@ Int valgrind_main ( Int argc, HChar **argv, HChar **envp )
         NSegment const* seg 
            = VG_(am_find_nsegment)( seg_starts[i] );
         vg_assert(seg);
-        vg_assert(seg->start == seg_starts[i] );
         if (seg->kind == SkFileC || seg->kind == SkAnonC) {
+          /* This next assertion is tricky.  If it is placed
+             immediately before this 'if', it very occasionally fails.
+             Why?  Because previous iterations of the loop may have
+             caused tools (via the new_mem_startup calls) to do
+             dynamic memory allocation, and that may affect the mapped
+             segments; in particular it may cause segment merging to
+             happen.  Hence we cannot assume that seg_starts[i], which
+             reflects the state of the world before we started this
+             loop, is the same as seg->start, as the latter reflects
+             the state of the world (viz, mappings) at this particular
+             iteration of the loop.
+
+             Why does moving it inside the 'if' make it safe?  Because
+             any dynamic memory allocation done by the tools will
+             affect only the state of Valgrind-owned segments, not of
+             Client-owned segments.  And the 'if' guards against that
+             -- we only get in here for Client-owned segments.
+
+             In other words: the loop may change the state of
+             Valgrind-owned segments as it proceeds.  But it should
+             not cause the Client-owned segments to change. */
+           vg_assert(seg->start == seg_starts[i]);
            VG_(debugLog)(2, "main", 
                             "tell tool about %010lx-%010lx %c%c%c\n",
                              seg->start, seg->end,