From: Linus Walleij Date: Tue, 24 Jun 2025 18:47:57 +0000 (+0200) Subject: pinctrl: amlogic: Staticize some local structs X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4ab401099d4764d1479914fd4c8b9876d5b3aca1;p=thirdparty%2Fkernel%2Flinux.git pinctrl: amlogic: Staticize some local structs Sparse complains: sparse warnings: (new ones prefixed by >>) >> drivers/pinctrl/meson/pinctrl-amlogic-a4.c:126:24: sparse: sparse: symbol 'multi_mux_s7' was not declared. Should it be static? >> drivers/pinctrl/meson/pinctrl-amlogic-a4.c:135:28: sparse: sparse: symbol 's7_priv_data' was not declared. Should it be static? >> drivers/pinctrl/meson/pinctrl-amlogic-a4.c:140:24: sparse: sparse: symbol 'multi_mux_s6' was not declared. Should it be static? >> drivers/pinctrl/meson/pinctrl-amlogic-a4.c:154:28: sparse: sparse: symbol 's6_priv_data' was not declared. Should it be static? Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202506122145.wWAtKBoy-lkp@intel.com/ Cc: Xianwei Zhao Fixes: 1f8e5dfddaa7 ("pinctrl: meson: support amlogic S6/S7/S7D SoC") Signed-off-by: Linus Walleij Link: https://lore.kernel.org/20250624-amlogic-a4-fix-v1-1-03f0856d10cb@linaro.org --- diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c index 2541c864086d6..c8958222df8c7 100644 --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c @@ -123,7 +123,7 @@ static const char *aml_bank_name[31] = { "GPIOCC", "TEST_N", "ANALOG" }; -const struct multi_mux multi_mux_s7[] = { +static const struct multi_mux multi_mux_s7[] = { { .m_bank_id = AMLOGIC_GPIO_CC, .m_bit_offs = 24, @@ -132,12 +132,12 @@ const struct multi_mux multi_mux_s7[] = { }, }; -const struct aml_pctl_data s7_priv_data = { +static const struct aml_pctl_data s7_priv_data = { .number = ARRAY_SIZE(multi_mux_s7), .p_mux = multi_mux_s7, }; -const struct multi_mux multi_mux_s6[] = { +static const struct multi_mux multi_mux_s6[] = { { .m_bank_id = AMLOGIC_GPIO_CC, .m_bit_offs = 24, @@ -151,7 +151,7 @@ const struct multi_mux multi_mux_s6[] = { }, }; -const struct aml_pctl_data s6_priv_data = { +static const struct aml_pctl_data s6_priv_data = { .number = ARRAY_SIZE(multi_mux_s6), .p_mux = multi_mux_s6, };