From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 30 Apr 2020 19:03:37 +0000 (-0400)
Subject: we don't need this code
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4abf5d80cbb2b3f9b5baac475e4d84cfb6995353;p=thirdparty%2Ffreeradius-server.git

we don't need this code
---

diff --git a/src/lib/unlang/map.c b/src/lib/unlang/map.c
index b9d2232e4da..0280478b165 100644
--- a/src/lib/unlang/map.c
+++ b/src/lib/unlang/map.c
@@ -169,15 +169,8 @@ static unlang_action_t list_mod_create(REQUEST *request, rlm_rcode_t *presult)
 
 		case UNLANG_UPDATE_MAP_EXPANDED_LHS:
 			/*
-			 *	Concat the top level results together
+			 *	map_to_list_mod() already concatentates the LHS, so we don't need to do it here.
 			 */
-			if (update_state->lhs_result &&
-			    (fr_value_box_list_concat(update_state, update_state->lhs_result, &update_state->lhs_result,
-						      FR_TYPE_STRING, true) < 0)) {
-				RPEDEBUG("Failed concatenating LHS expansion results");
-				goto error;
-			}
-
 			if (!map->rhs) goto next;
 
 			update_state->state = UNLANG_UPDATE_MAP_EXPANDED_RHS;