From: Olivier Houchard <ohouchard@haproxy.com>
Date: Tue, 29 Apr 2025 13:25:53 +0000 (+0200)
Subject: MINOR: tasks: Remove unused tasklet_remove_from_tasklet_list
X-Git-Tag: v3.2-dev13~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4abfade371100de8e159da47ca006c0bbaffee4d;p=thirdparty%2Fhaproxy.git

MINOR: tasks: Remove unused tasklet_remove_from_tasklet_list

Remove tasklet_remove_from_tasklet_list, as the function hasn't been
used for a long time, and there is little reason to keep it.
---

diff --git a/include/haproxy/task.h b/include/haproxy/task.h
index b1e7ab317..b1252ed68 100644
--- a/include/haproxy/task.h
+++ b/include/haproxy/task.h
@@ -534,21 +534,6 @@ static inline struct list *_tasklet_wakeup_after(struct list *head, struct taskl
 #define DEBUG_TASK_PRINT_CALLER(t) do { } while (0)
 #endif
 
-
-/* Try to remove a tasklet from the list. This call is inherently racy and may
- * only be performed on the thread that was supposed to dequeue this tasklet.
- * This way it is safe to call MT_LIST_DELETE without first removing the
- * TASK_QUEUED bit, which must absolutely be removed afterwards in case
- * another thread would want to wake this tasklet up in parallel.
- */
-static inline void tasklet_remove_from_tasklet_list(struct tasklet *t)
-{
-	if (MT_LIST_DELETE(list_to_mt_list(&t->list))) {
-		_HA_ATOMIC_AND(&t->state, ~TASK_QUEUED);
-		_HA_ATOMIC_DEC(&ha_thread_ctx[t->tid >= 0 ? t->tid : tid].rq_total);
-	}
-}
-
 /*
  * Initialize a new task. The bare minimum is performed (queue pointers and
  * state).  The task is returned. This function should not be used outside of