From: David Lawrence <dkl@mozilla.com>
Date: Tue, 29 Apr 2014 15:21:40 +0000 (+0000)
Subject: Bug 1002775 - For the purpose of continuous integration testing, makedocs.pl should... 
X-Git-Tag: bugzilla-4.5.5~77^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4ad3e5877d3e01b8de6f9a54d0f12ed3827c2ff8;p=thirdparty%2Fbugzilla.git

Bug 1002775 - For the purpose of continuous integration testing, makedocs.pl should return failed status if one or more errors occurred building docs
r/a=glob
---

diff --git a/docs/makedocs.pl b/docs/makedocs.pl
index d14e79434b..4f0f52579d 100755
--- a/docs/makedocs.pl
+++ b/docs/makedocs.pl
@@ -57,12 +57,14 @@ use File::Which qw(which);
 # Subs
 ###############################################################################
 
+my $error_found = 0;
 sub MakeDocs {
     my ($name, $cmdline) = @_;
 
     say "Creating $name documentation ..." if defined $name;
     say "$cmdline\n";
-    system $cmdline;
+    system($cmdline) == 0
+        or $error_found = 1;
     print "\n";
 }
 
@@ -160,3 +162,5 @@ foreach my $lang (@langs) {
 
     rmtree('doctrees', 0, 1);
 }
+
+die "Error occurred building the documentation\n" if $error_found;