From: Patrick H. Lauke Date: Tue, 19 Feb 2019 09:25:37 +0000 (+0000) Subject: Remove incorrect aria-haspopup from dropdown toggles (#28299) X-Git-Tag: v5.0.0-alpha1~1352 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4b00aa6c4ec9281ad27659babb0e208ab6cdeafa;p=thirdparty%2Fbootstrap.git Remove incorrect aria-haspopup from dropdown toggles (#28299) `aria-haspopup` use requires the use of an ARIA `menu`, `listbox`, `tree`, `grid` or `dialog` (see https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup) in our use (as generic disclosure widgets), it's incorrect and sets up the wrong assumption/behavior from assistive technologies. in future, we likely want to change our dropdowns to essentially be like a `dialog` - move focus to it when opened, possibly make it modal so focus is maintained inside it and the rest of the page is hidden/inert. but for now, removing the incorrect attribute is probably the quickest, most immediate fix. --- diff --git a/js/tests/unit/dropdown.js b/js/tests/unit/dropdown.js index 1ecfd1f8bf..a94595ad20 100644 --- a/js/tests/unit/dropdown.js +++ b/js/tests/unit/dropdown.js @@ -727,7 +727,7 @@ $(function () { var done = assert.async() var html = '