From: Sami Kerola <kerolasa@iki.fi>
Date: Tue, 7 Feb 2012 21:55:56 +0000 (+0100)
Subject: chcpu: use appropriate variable type [cppcheck]
X-Git-Tag: v2.21~36
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4b11df2cf50fc324bdc4cb507d773520fb33a896;p=thirdparty%2Futil-linux.git

chcpu: use appropriate variable type [cppcheck]

[sys-utils/chcpu.c:251]: (style) Checking if unsigned variable 'maxcpus' is less than zero.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/sys-utils/chcpu.c b/sys-utils/chcpu.c
index 29b7ab8965..79f5167550 100644
--- a/sys-utils/chcpu.c
+++ b/sys-utils/chcpu.c
@@ -47,7 +47,7 @@
 #define _PATH_SYS_CPU_DISPATCH	_PATH_SYS_CPU "/dispatching"
 
 static cpu_set_t *onlinecpus;
-static size_t maxcpus;
+static int maxcpus;
 
 #define is_cpu_online(cpu) (CPU_ISSET_S((cpu), CPU_ALLOC_SIZE(maxcpus), onlinecpus))
 #define num_online_cpus()  (CPU_COUNT_S(CPU_ALLOC_SIZE(maxcpus), onlinecpus))
@@ -248,7 +248,7 @@ int main(int argc, char *argv[])
 	textdomain(PACKAGE);
 
 	maxcpus = get_max_number_of_cpus();
-	if ((int) maxcpus <= 0)
+	if (maxcpus < 1)
 		errx(EXIT_FAILURE, _("cannot determine NR_CPUS; aborting"));
 	if (path_exist(_PATH_SYS_CPU_ONLINE))
 		onlinecpus = path_cpulist(maxcpus, _PATH_SYS_CPU_ONLINE);