From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sun, 27 Jan 2019 06:41:11 +0000 (+0700)
Subject:  clang scan bug
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4b1d3a424edce61ff14e5cf2feefb0c416b185a3;p=thirdparty%2Ffreeradius-server.git

 clang scan bug
---

diff --git a/src/lib/server/cond_tokenize.c b/src/lib/server/cond_tokenize.c
index db9b140079f..c0463ad473e 100644
--- a/src/lib/server/cond_tokenize.c
+++ b/src/lib/server/cond_tokenize.c
@@ -254,7 +254,11 @@ static ssize_t cond_tokenize_word(TALLOC_CTX *ctx, char const *start, char **out
 			*error = "Unexpected escape";
 		error:
 			*out = NULL;
-			return start - p;	/* clang scan doesn't like -(p - start) */
+#ifdef __clang_analyzer__
+			return 0;	/* clang analyzer bug.  Determines p < start in same cases */
+#else
+			return -(p - start);
+#endif
 		}
 
 		/*