From: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Date: Fri, 9 Dec 2022 18:34:54 +0000 (+0100)
Subject: cgroups: check snprintf retval in unpriv_systemd_create_scope
X-Git-Tag: lxc-5.0.2~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4b434bf52f696d1102cc140290aec76e193fef85;p=thirdparty%2Flxc.git

cgroups: check snprintf retval in unpriv_systemd_create_scope

Reported-by: coverity (CID #1517315)
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
---

diff --git a/src/lxc/cgroups/cgfsng.c b/src/lxc/cgroups/cgfsng.c
index 8a3693d29..eeb817334 100644
--- a/src/lxc/cgroups/cgfsng.c
+++ b/src/lxc/cgroups/cgfsng.c
@@ -1268,7 +1268,9 @@ static int unpriv_systemd_create_scope(struct cgroup_ops *ops, struct lxc_conf *
 		return syserror("Out of memory");
 
 	do {
-		snprintf(full_scope_name, len, "lxc-%s-%d.scope", conf->name, idx);
+		r = strnprintf(full_scope_name, len, "lxc-%s-%d.scope", conf->name, idx);
+		if (r < 0)
+			return log_error_errno(-1, errno, "Failed to build scope name for \"%s\"", conf->name);
 		sd_data.scope_name = full_scope_name;
 		if (start_scope(bus, &sd_data, event)) {
 			conf->cgroup_meta.systemd_scope = get_current_unified_cgroup();