From: Pierre Chifflier <chifflier@wzdftpd.net>
Date: Sat, 13 Jan 2018 15:09:26 +0000 (+0100)
Subject: NTP: ensure parser name is not freed after registration
X-Git-Tag: suricata-4.1.0-beta1~355
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4b6555588f60ba2c6819a859e53b3b2263749592;p=thirdparty%2Fsuricata.git

NTP: ensure parser name is not freed after registration
---

diff --git a/rust/src/ntp/ntp.rs b/rust/src/ntp/ntp.rs
index 92a4b029e0..5e7043279a 100644
--- a/rust/src/ntp/ntp.rs
+++ b/rust/src/ntp/ntp.rs
@@ -377,12 +377,13 @@ pub extern "C" fn ntp_probing_parser(_flow: *const Flow, input:*const u8, input_
     }
 }
 
+const PARSER_NAME : &'static [u8] = b"ntp\0";
+
 #[no_mangle]
 pub unsafe extern "C" fn rs_register_ntp_parser() {
-    let name = CString::new("ntp").unwrap();
     let default_port = CString::new("123").unwrap();
     let parser = RustParser {
-        name              : name.as_ptr(),
+        name              : PARSER_NAME.as_ptr() as *const libc::c_char,
         default_port      : default_port.as_ptr(),
         ipproto           : libc::IPPROTO_UDP,
         probe_ts          : ntp_probing_parser,