From: zhangdongchuan@eswincomputing.com Date: Wed, 26 Nov 2025 03:40:16 +0000 (+0800) Subject: virtio_ring: code cleanup in detach_buf_split X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4b7bf8d5503287ed3bd661207b9d061999ac494e;p=thirdparty%2Flinux.git virtio_ring: code cleanup in detach_buf_split Since the return value of vring_unmap_one_split() is exactly vq->split.desc_extra[i].next, 'i = vq->split.desc_extra[i].next' is redundant. Assign vring_unmap_one_split() to i instead. Since vq->split.desc_extra is assigned to extra, use extra[i].next instead of vq->split.desc_extra[i].next to improve readability. No change in functionality. Signed-off-by: zhangdongchuan Acked-by: Jason Wang Signed-off-by: Michael S. Tsirkin Message-Id: <202511261140162936986@eswincomputing.com> --- diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index ddab689596717..560e132f1f193 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -764,13 +764,12 @@ static void detach_buf_split(struct vring_virtqueue *vq, unsigned int head, i = head; while (vq->split.vring.desc[i].flags & nextflag) { - vring_unmap_one_split(vq, &extra[i]); - i = vq->split.desc_extra[i].next; + i = vring_unmap_one_split(vq, &extra[i]); vq->vq.num_free++; } vring_unmap_one_split(vq, &extra[i]); - vq->split.desc_extra[i].next = vq->free_head; + extra[i].next = vq->free_head; vq->free_head = head; /* Plus final descriptor */