From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Tue, 15 May 2018 10:35:34 +0000 (+0200)
Subject: coverity: #1435602
X-Git-Tag: lxc-3.1.0~304^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4b812aca236191cb86d18108102f750d9cd28c7f;p=thirdparty%2Flxc.git

coverity: #1435602

Resource leak

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/storage/btrfs.c b/src/lxc/storage/btrfs.c
index a9ab7988a..be07aeb6f 100644
--- a/src/lxc/storage/btrfs.c
+++ b/src/lxc/storage/btrfs.c
@@ -254,8 +254,11 @@ static int btrfs_subvolume_create(const char *path)
 
 	memset(&args, 0, sizeof(args));
 	retlen = strlcpy(args.name, p + 1, BTRFS_SUBVOL_NAME_MAX);
-	if (retlen >= BTRFS_SUBVOL_NAME_MAX)
+	if (retlen >= BTRFS_SUBVOL_NAME_MAX) {
+		free(newfull);
+		close(fd);
 		return -E2BIG;
+	}
 
 	ret = ioctl(fd, BTRFS_IOC_SUBVOL_CREATE, &args);
 	saved_errno = errno;