From: Amos Jeffries <squid3@treenet.co.nz>
Date: Wed, 22 Jan 2014 03:17:25 +0000 (-0700)
Subject: Fix memory leak in peer cache Digest exchange
X-Git-Tag: SQUID_3_4_3~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4b8274d79bcde2d9951cdcaaa03b67f8c237ddd5;p=thirdparty%2Fsquid.git

Fix memory leak in peer cache Digest exchange

 Detected by Coverity Scan. Issue 1094115.
---

diff --git a/src/peer_digest.cc b/src/peer_digest.cc
index 0d303a99d4..7cf1486477 100644
--- a/src/peer_digest.cc
+++ b/src/peer_digest.cc
@@ -300,7 +300,7 @@ peerDigestRequest(PeerDigest * pd)
 {
     CachePeer *p = pd->peer;
     StoreEntry *e, *old_e;
-    char *url;
+    char *url = NULL;
     const cache_key *key;
     HttpRequest *req;
     DigestFetchState *fetch = NULL;
@@ -398,6 +398,8 @@ peerDigestRequest(PeerDigest * pd)
 
     storeClientCopy(fetch->sc, e, tempBuffer,
                     peerDigestHandleReply, fetch);
+
+    safe_free(url);
 }
 
 /* Handle the data copying .. */