From: Simon McVittie Date: Wed, 25 May 2011 15:02:43 +0000 (+0100) Subject: Relax review criteria for the review cabal themselves, as discussed on-list X-Git-Tag: dbus-1.4.10~25 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4bcffe1e05cfc22eb29b41d39f7ceca14b45a9a8;p=thirdparty%2Fdbus.git Relax review criteria for the review cabal themselves, as discussed on-list Colin agreed in principle and nobody actually objected, so here we go... --- diff --git a/HACKING b/HACKING index 036961f23..bebf7ac19 100644 --- a/HACKING +++ b/HACKING @@ -298,6 +298,20 @@ rules are: - if there's a live unresolved controversy about a change, don't commit it while the argument is still raging. + - at their discretion, members of the reviewer group may also commit + branches/patches under these conditions: + + - the branch does not add or change API, ABI or wire-protocol + + - the branch solves a known problem and is covered by the regression tests + + - there are no objections from the rest of the review group within + a week of the patches being attached to Bugzilla + + - the committer gets a positive review on Bugzilla from someone they + consider qualified to review the change (e.g. a colleague with D-Bus + experience; not necessarily a member of the reviewer group) + - regardless of reviews, to commit a patch: - make check must pass - the test suite must be extended to cover the new code