From: Doug Kearns <dougkearns@gmail.com>
Date: Sun, 14 Dec 2025 15:41:03 +0000 (+0100)
Subject: patch 9.1.1979: :helpclose allows range and counts
X-Git-Tag: v9.1.1979^0
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4c141bae3bd7afd7eb63c72c835d356fbdff61e2;p=thirdparty%2Fvim.git

patch 9.1.1979: :helpclose allows range and counts

Problem:  :helpclose incorrectly accepts a range and a count.
Solution: Remove EX_COUNT and EX_RANGE from the command definition.
          (Doug Kearns)

closes: #18917

Signed-off-by: Doug Kearns <dougkearns@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
---

diff --git a/src/ex_cmds.h b/src/ex_cmds.h
index d588be3b95..48b69ea824 100644
--- a/src/ex_cmds.h
+++ b/src/ex_cmds.h
@@ -693,8 +693,8 @@ EXCMD(CMD_help,		"help",		ex_help,
 	EX_BANG|EX_EXTRA|EX_NOTRLCOM,
 	ADDR_NONE),
 EXCMD(CMD_helpclose,	"helpclose",	ex_helpclose,
-	EX_RANGE|EX_COUNT|EX_TRLBAR,
-	ADDR_OTHER),
+	EX_TRLBAR,
+	ADDR_NONE),
 EXCMD(CMD_helpfind,	"helpfind",	ex_helpfind,
 	EX_EXTRA|EX_NOTRLCOM,
 	ADDR_NONE),
diff --git a/src/testdir/test_help.vim b/src/testdir/test_help.vim
index 820338abdc..33e5234b52 100644
--- a/src/testdir/test_help.vim
+++ b/src/testdir/test_help.vim
@@ -58,6 +58,13 @@ func Test_help_errors()
   bwipe!
 endfunc
 
+func Test_helpclose_errors()
+  call assert_fails('42helpclose', 'E481:')
+  call assert_fails('helpclose 42', 'E488:')
+  call assert_fails('helpclose foo', 'E488:')
+  call assert_fails('helpclose!', 'E477:')
+endfunc
+
 func Test_help_expr()
   help expr-!~?
   call assert_equal('eval.txt', expand('%:t'))
diff --git a/src/version.c b/src/version.c
index 5c19e6baa2..d62c453f1b 100644
--- a/src/version.c
+++ b/src/version.c
@@ -734,6 +734,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1979,
 /**/
     1978,
 /**/