From: lpsolit%gmail.com <>
Date: Wed, 6 Aug 2008 02:55:48 +0000 (+0000)
Subject: Bug 449248: Improve $product->group_controls - Patch by Frédéric Buclin <LpSolit... 
X-Git-Tag: bugzilla-3.2rc1~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4c3608f8015f2ff14d7f6cfd3ff7edc5f736fda2;p=thirdparty%2Fbugzilla.git

Bug 449248: Improve $product->group_controls - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
---

diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm
index edc621f670..95a0e38407 100644
--- a/Bugzilla/Product.pm
+++ b/Bugzilla/Product.pm
@@ -120,10 +120,11 @@ sub group_controls {
                   ORDER BY groups.name};
         $self->{group_controls} = 
             $dbh->selectall_hashref($query, 'id', undef, $self->id);
-        foreach my $group (keys(%{$self->{group_controls}})) {
-            $self->{group_controls}->{$group}->{'group'} = 
-                new Bugzilla::Group($group);
-        }
+
+        # For each group ID listed above, create and store its group object.
+        my @gids = keys %{$self->{group_controls}};
+        my $groups = Bugzilla::Group->new_from_list(\@gids);
+        $self->{group_controls}->{$_->id}->{group} = $_ foreach @$groups;
     }
     return $self->{group_controls};
 }