From: Dr. David von Oheimb Date: Mon, 8 Mar 2021 07:04:54 +0000 (+0100) Subject: cmp_hdr.c: Fix minor Coverity issue CID 1473605 X-Git-Tag: openssl-3.0.0-alpha13~19 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4c52ee1dbfa1913a14968f395cc9900ed9beee5e;p=thirdparty%2Fopenssl.git cmp_hdr.c: Fix minor Coverity issue CID 1473605 Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/14460) --- diff --git a/crypto/cmp/cmp_hdr.c b/crypto/cmp/cmp_hdr.c index 58b07dd8b2e..a1770c1204b 100644 --- a/crypto/cmp/cmp_hdr.c +++ b/crypto/cmp/cmp_hdr.c @@ -283,9 +283,6 @@ int ossl_cmp_hdr_set_transactionID(OSSL_CMP_CTX *ctx, OSSL_CMP_PKIHEADER *hdr) OPENSSL_free(tid); } - if (ctx->transactionID == NULL - && !set_random(&ctx->transactionID, ctx, OSSL_CMP_TRANSACTIONID_LENGTH)) - return 0; return ossl_cmp_asn1_octet_string_set1(&hdr->transactionID, ctx->transactionID); }