From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 28 May 2014 19:42:01 +0000 (-0400)
Subject: Fix bogus %name-prefix option syntax in all our Bison files.
X-Git-Tag: REL9_1_14~34
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4c5fde4e288983f30dae09a7eea8e6a9e6145477;p=thirdparty%2Fpostgresql.git

Fix bogus %name-prefix option syntax in all our Bison files.

%name-prefix doesn't use an "=" sign according to the Bison docs, but it
silently accepted one anyway, until Bison 3.0.  This was originally a
typo of mine in commit 012abebab1bc72043f3f670bf32e91ae4ee04bd2, and we
seem to have slavishly copied the error into all the other grammar files.

Per report from Vik Fearing; analysis by Peter Eisentraut.

Back-patch to all active branches, since somebody might try to build
a back branch with up-to-date tools.
---

diff --git a/contrib/cube/cubeparse.y b/contrib/cube/cubeparse.y
index eda5ba9604d..1cbb1cb49e4 100644
--- a/contrib/cube/cubeparse.y
+++ b/contrib/cube/cubeparse.y
@@ -39,7 +39,7 @@ static NDBOX * write_point_as_box(char *s, int dim);
 /* BISON Declarations */
 %parse-param {NDBOX **result}
 %expect 0
-%name-prefix="cube_yy"
+%name-prefix "cube_yy"
 
 %token CUBEFLOAT O_PAREN C_PAREN O_BRACKET C_BRACKET COMMA
 %start box
diff --git a/contrib/seg/segparse.y b/contrib/seg/segparse.y
index 538d06e5339..177bf06fb2d 100644
--- a/contrib/seg/segparse.y
+++ b/contrib/seg/segparse.y
@@ -42,7 +42,7 @@
 /* BISON Declarations */
 %parse-param {SEG *result}
 %expect 0
-%name-prefix="seg_yy"
+%name-prefix "seg_yy"
 
 %union {
   struct BND {
diff --git a/src/backend/bootstrap/bootparse.y b/src/backend/bootstrap/bootparse.y
index c6b755628b2..0f4a471a6da 100644
--- a/src/backend/bootstrap/bootparse.y
+++ b/src/backend/bootstrap/bootparse.y
@@ -93,7 +93,7 @@ static int num_columns_read = 0;
 %}
 
 %expect 0
-%name-prefix="boot_yy"
+%name-prefix "boot_yy"
 
 %union
 {
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index 2108c8289c6..f5f24380d0e 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -148,7 +148,7 @@ static void processCASbits(int cas_bits, int location, const char *constrType,
 
 %pure-parser
 %expect 0
-%name-prefix="base_yy"
+%name-prefix "base_yy"
 %locations
 
 %parse-param {core_yyscan_t yyscanner}
diff --git a/src/backend/replication/repl_gram.y b/src/backend/replication/repl_gram.y
index d99708ca8eb..a9f920e35ab 100644
--- a/src/backend/replication/repl_gram.y
+++ b/src/backend/replication/repl_gram.y
@@ -49,7 +49,7 @@ Node *replication_parse_result;
 %}
 
 %expect 0
-%name-prefix="replication_yy"
+%name-prefix "replication_yy"
 
 %union {
 		char					*str;
diff --git a/src/interfaces/ecpg/preproc/ecpg.header b/src/interfaces/ecpg/preproc/ecpg.header
index 80c90feb6a6..aebc1f7d3e3 100644
--- a/src/interfaces/ecpg/preproc/ecpg.header
+++ b/src/interfaces/ecpg/preproc/ecpg.header
@@ -456,7 +456,7 @@ add_typedef(char *name, char * dimension, char * length, enum ECPGttype type_enu
 %}
 
 %expect 0
-%name-prefix="base_yy"
+%name-prefix "base_yy"
 %locations
 
 %union {
diff --git a/src/pl/plpgsql/src/gram.y b/src/pl/plpgsql/src/gram.y
index 4e2b7058f0c..426aced5a37 100644
--- a/src/pl/plpgsql/src/gram.y
+++ b/src/pl/plpgsql/src/gram.y
@@ -109,7 +109,7 @@ static	List			*read_raise_options(void);
 %}
 
 %expect 0
-%name-prefix="plpgsql_yy"
+%name-prefix "plpgsql_yy"
 %locations
 
 %union {
diff --git a/src/test/isolation/specparse.y b/src/test/isolation/specparse.y
index 47bfbc4f399..4a5af738628 100644
--- a/src/test/isolation/specparse.y
+++ b/src/test/isolation/specparse.y
@@ -20,7 +20,7 @@ TestSpec		parseresult;			/* result of parsing is left here */
 %}
 
 %expect 0
-%name-prefix="spec_yy"
+%name-prefix "spec_yy"
 
 %union
 {