From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Tue, 23 May 2023 00:48:56 +0000 (+1200)
Subject: s4/messaging/py: Check py_return_ndr_struct() return value
X-Git-Tag: talloc-2.4.1~593
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4c67cac68b7129c6109c6bb415ae0ff2b0ea679c;p=thirdparty%2Fsamba.git

s4/messaging/py: Check py_return_ndr_struct() return value

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/lib/messaging/pymessaging.c b/source4/lib/messaging/pymessaging.c
index 80ca7a99073..2fb201edf29 100644
--- a/source4/lib/messaging/pymessaging.c
+++ b/source4/lib/messaging/pymessaging.c
@@ -218,6 +218,9 @@ static void py_msg_callback_wrapper(struct imessaging_context *msg,
 
 	py_server_id = py_return_ndr_struct("samba.dcerpc.server_id", "server_id", p_server_id, p_server_id);
 	talloc_unlink(NULL, p_server_id);
+	if (py_server_id == NULL) {
+		return;
+	}
 
 	result = PyObject_CallFunction(callback, discard_const_p(char, "OiOs#"),
 				       py_private,