From: Rico Tzschichholz Date: Thu, 17 Oct 2019 06:50:14 +0000 (+0200) Subject: codegen: Drop unreachable and misplaced code X-Git-Tag: 0.44.10~35 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4cb04ace24e7473191268077e3651af5e3c369a4;p=thirdparty%2Fvala.git codegen: Drop unreachable and misplaced code Dropped with 8aa6299ea7a39e7a652ce3896324aaa47af99a18 and falsely reintroduced with 7a429688cdf0fd16cc1503a7666681792e309da8 --- diff --git a/codegen/valaccodemethodmodule.vala b/codegen/valaccodemethodmodule.vala index 2546b4d8a..89e65a38d 100644 --- a/codegen/valaccodemethodmodule.vala +++ b/codegen/valaccodemethodmodule.vala @@ -773,23 +773,6 @@ public abstract class Vala.CCodeMethodModule : CCodeStructModule { creturn_type = new VoidType (); } - - if (current_type_symbol is Class && gobject_type != null && current_class.is_subtype_of (gobject_type) - && current_class.has_type_parameters () - && !((CreationMethod) m).chain_up) { - var ccond = new CCodeBinaryExpression (CCodeBinaryOperator.GREATER_THAN, new CCodeIdentifier ("__params_it"), new CCodeIdentifier ("__params")); - ccode.open_while (ccond); - ccode.add_expression (new CCodeUnaryExpression (CCodeUnaryOperator.PREFIX_DECREMENT, new CCodeIdentifier ("__params_it"))); - var cunsetcall = new CCodeFunctionCall (new CCodeIdentifier ("g_value_unset")); - cunsetcall.add_argument (new CCodeUnaryExpression (CCodeUnaryOperator.ADDRESS_OF, new CCodeMemberAccess.pointer (new CCodeIdentifier ("__params_it"), "value"))); - ccode.add_expression (cunsetcall); - ccode.close (); - - var cfreeparams = new CCodeFunctionCall (new CCodeIdentifier ("g_free")); - cfreeparams.add_argument (new CCodeIdentifier ("__params")); - ccode.add_expression (cfreeparams); - } - if (current_type_symbol is Class && !m.coroutine) { CCodeExpression cresult = new CCodeIdentifier ("self"); if (get_ccode_type (m) != null) {