From: Jonathon Jongsma <jjongsma@redhat.com>
Date: Fri, 20 Mar 2020 14:43:13 +0000 (-0500)
Subject: api: disallow virDomainAgentSetResponseTimeout() on read-only connections
X-Git-Tag: v6.2.0-rc1~101
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4cc90c2e62df653e909ad31fd810224bf8bcf913;p=thirdparty%2Flibvirt.git

api: disallow virDomainAgentSetResponseTimeout() on read-only connections

This function changes the amount of time that libvirt waits for a
response from the guest agent for all guest agent commands. Since this
is a configuration change, it should not be allowed on read-only
connections.

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 65813b68cc..a12809c2d5 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -12576,6 +12576,8 @@ virDomainAgentSetResponseTimeout(virDomainPtr domain,
     virCheckDomainReturn(domain, -1);
     conn = domain->conn;
 
+    virCheckReadOnlyGoto(conn->flags, error);
+
     if (conn->driver->domainAgentSetResponseTimeout) {
         if (conn->driver->domainAgentSetResponseTimeout(domain, timeout, flags) < 0)
             goto error;