From: Jakub Jelinek <jakub@redhat.com>
Date: Thu, 23 Jan 2025 22:06:07 +0000 (+0100)
Subject: c++: Small make_tree_vector_from_ctor improvement
X-Git-Tag: basepoints/gcc-16~2385
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4ce9e35396205ee1674658a9b844ccdf80044378;p=thirdparty%2Fgcc.git

c++: Small make_tree_vector_from_ctor improvement

After committing the append_ctor_to_tree_vector patch, I've realized
that for the larger constructors make_tree_vector_from_ctor unnecessarily
wastes one GC vector; make_tree_vector () / release_tree_vector () only
caches GC vectors from 4 to 16 allocated tree elements, so in the likely
case of a rather small ctor using make_tree_vector () can be beneficial,
we can pick something from the cache and if we don't need it later,
pt.cc calls release_tree_vector on it to return it back to the cache.
But for the larger ctors, we just eat one vector from the cache, never
use it (because the vec_safe_reserve will immediately allocate a different
vector) and never return it back to the cache.

So, the following patch passes NULL for the larger vectors, which
append_ctor_to_tree_vector handles just fine now (vec_safe_reserve will
just allocate appropriately sized vector).

2025-01-23  Jakub Jelinek  <jakub@redhat.com>

	* c-common.cc (make_tree_vector_from_ctor): Only use make_tree_vector
	for ctors with <= 16 elements.
---

diff --git a/gcc/c-family/c-common.cc b/gcc/c-family/c-common.cc
index c193eb2c463..49508fe9ee6 100644
--- a/gcc/c-family/c-common.cc
+++ b/gcc/c-family/c-common.cc
@@ -9044,7 +9044,8 @@ append_ctor_to_tree_vector (vec<tree, va_gc> *v, tree ctor)
 vec<tree, va_gc> *
 make_tree_vector_from_ctor (tree ctor)
 {
-  vec<tree,va_gc> *ret = make_tree_vector ();
+  vec<tree,va_gc> *ret
+    = CONSTRUCTOR_NELTS (ctor) <= 16 ? make_tree_vector () : NULL;
   return append_ctor_to_tree_vector (ret, ctor);
 }