From: Nick Porter <nick@portercomputing.co.uk>
Date: Mon, 30 Dec 2024 18:06:11 +0000 (+0000)
Subject: Attempt to pacify Coverity (CID #1604608)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4cf2a5359f969a8eecdbff2bd0e1c1ce7bb36b66;p=thirdparty%2Ffreeradius-server.git

Attempt to pacify Coverity (CID #1604608)
---

diff --git a/src/modules/rlm_mschap/rlm_mschap.c b/src/modules/rlm_mschap/rlm_mschap.c
index 05420265c5c..8fe6ef4634a 100644
--- a/src/modules/rlm_mschap/rlm_mschap.c
+++ b/src/modules/rlm_mschap/rlm_mschap.c
@@ -819,6 +819,15 @@ static int write_all(int fd, char const *buf, size_t len) {
 		rv = write(fd, buf+done, len-done);
 		if (rv <= 0)
 			break;
+
+#ifdef STATIC_ANALYZER
+		/*
+		 *	Coverity doesn't appear to know the limits on the
+		 *	return value of write() - so beleives an overflow can happen
+		 */
+		if (rv > (len - done)) break;
+#endif
+
 		done += rv;
 	}
 	rv = write(fd, "\n", 1);