From: Nick Porter <nick@portercomputing.co.uk>
Date: Fri, 26 Aug 2022 12:51:35 +0000 (+0100)
Subject: Quiet clang scan
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4cfa99a82ce913a4997d602d0a171bb5a1eec5ce;p=thirdparty%2Ffreeradius-server.git

Quiet clang scan
---

diff --git a/src/lib/server/tmpl_eval.c b/src/lib/server/tmpl_eval.c
index 888a55ea5b8..20fce154b92 100644
--- a/src/lib/server/tmpl_eval.c
+++ b/src/lib/server/tmpl_eval.c
@@ -1098,10 +1098,10 @@ int pair_append_by_tmpl_parent(TALLOC_CTX *ctx, fr_pair_t **out, fr_pair_list_t
 	 *	attributes and then allocating the leaf.
 	 */
 	while (true) {
+		if (unlikely(!ar)) goto error;
 		/*
 		 *	We're not at the leaf, look for a potential parent
 		 */
-		fr_assert(ar);
 		if (ar != leaf) vp = fr_pair_find_by_da(list, NULL, ar->da);
 
 		/*