From: mkanat%bugzilla.org <>
Date: Mon, 3 Aug 2009 15:13:50 +0000 (+0000)
Subject: Bug 508032: Speed up initializing of email_setting values
X-Git-Tag: bugzilla-3.5.1~137
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4d04866100b1566d062f7b10c561877c49a9c6a5;p=thirdparty%2Fbugzilla.git

Bug 508032: Speed up initializing of email_setting values
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat
---

diff --git a/Bugzilla/Install/DB.pm b/Bugzilla/Install/DB.pm
index 09b1108941..48fc066303 100644
--- a/Bugzilla/Install/DB.pm
+++ b/Bugzilla/Install/DB.pm
@@ -2222,17 +2222,9 @@ sub _clone_email_event {
     my ($source, $target) = @_;
     my $dbh = Bugzilla->dbh;
 
-    my $sth1 = $dbh->prepare("SELECT user_id, relationship FROM email_setting
-                              WHERE event = $source");
-    my $sth2 = $dbh->prepare("INSERT into email_setting " .
-                             "(user_id, relationship, event) VALUES (" .
-                             "?, ?, $target)");
-
-    $sth1->execute();
-
-    while (my ($userid, $relationship) = $sth1->fetchrow_array()) {
-        $sth2->execute($userid, $relationship);
-    }
+    $dbh->do("INSERT INTO email_setting (user_id, relationship, event)
+                   SELECT user_id, relationship, $target FROM email_setting
+                    WHERE event = $source");
 }
 
 sub _migrate_email_prefs_to_new_table {