From: Michael R Sweet <michael.r.sweet@gmail.com>
Date: Tue, 7 Sep 2021 13:28:35 +0000 (-0400)
Subject: Fix potential deadlock (Issue #243)
X-Git-Tag: v2.4b1~71
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4d058a7ed5766f036b377ce9572e22acd2546bfc;p=thirdparty%2Fcups.git

Fix potential deadlock (Issue #243)
---

diff --git a/cups/tls-darwin.c b/cups/tls-darwin.c
index b3bd50bf81..0741a320e7 100644
--- a/cups/tls-darwin.c
+++ b/cups/tls-darwin.c
@@ -1,7 +1,8 @@
 /*
  * TLS support code for CUPS on macOS.
  *
- * Copyright © 2007-2019 by Apple Inc.
+ * Copyright © 2021 by OpenPrinting
+ * Copyright © 2007-2021 by Apple Inc.
  * Copyright © 1997-2007 by Easy Software Products, all rights reserved.
  *
  * Licensed under Apache License v2.0.  See the file "LICENSE" for more
@@ -291,7 +292,7 @@ cupsMakeServerCredentials(
     else
       tls_selfsigned = ident;
 
-    _cupsMutexLock(&tls_mutex);
+    _cupsMutexUnlock(&tls_mutex);
 
 #  if 0 /* Someday perhaps SecItemCopyMatching will work for identities, at which point  */
     CFTypeRef itemKeys[] = { kSecClass, kSecAttrLabel, kSecValueRef };