From: Jim Meyering <meyering@redhat.com>
Date: Tue, 18 May 2010 08:19:30 +0000 (+0200)
Subject: virDomainNetDefParseXML: avoid leak upon multiple "filterref"
X-Git-Tag: v0.8.2~256
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4d2adaa1d51981b219505dfd31c0d5f912f90d08;p=thirdparty%2Flibvirt.git

virDomainNetDefParseXML: avoid leak upon multiple "filterref"

* src/conf/domain_conf.c (virDomainNetDefParseXML): Don't leak
memory when parsing two or more "filterref" elements.
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3e45f7959f..20c9c51883 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -1905,6 +1905,7 @@ virDomainNetDefParseXML(virCapsPtr caps,
                 model = virXMLPropString(cur, "type");
             } else if (xmlStrEqual (cur->name, BAD_CAST "filterref")) {
                 filter = virXMLPropString(cur, "filter");
+                VIR_FREE(filterparams);
                 filterparams = virNWFilterParseParamAttributes(cur);
             } else if ((flags & VIR_DOMAIN_XML_INTERNAL_STATUS) &&
                        xmlStrEqual(cur->name, BAD_CAST "state")) {