From: Frédéric Buclin <LpSolit@gmail.com>
Date: Mon, 19 Sep 2011 15:36:53 +0000 (+0200)
Subject: Bug 686904: Removing an invalid URL from the See Also field crashes Bugzilla
X-Git-Tag: bugzilla-4.2rc1~59
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4d7f8b007dc0bac0ef2924302dbe2bdc0c049452;p=thirdparty%2Fbugzilla.git

Bug 686904: Removing an invalid URL from the See Also field crashes Bugzilla
r=timello a=LpSolit
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index e5b288f250..175bcd0500 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -2889,7 +2889,8 @@ sub remove_see_also {
     # Since we remove also the url from the referenced bug,
     # we need to notify changes for that bug too.
     $removed_bug_url = $removed_bug_url->[0];
-    if ($removed_bug_url->isa('Bugzilla::BugUrl::Bugzilla::Local')
+    if ($removed_bug_url
+        and $removed_bug_url->isa('Bugzilla::BugUrl::Bugzilla::Local')
         and defined $removed_bug_url->ref_bug_url)
     {
         push @{ $self->{see_also_changes} },
@@ -3383,7 +3384,7 @@ sub reporter {
 sub see_also {
     my ($self) = @_;
     return [] if $self->{'error'};
-    if (!defined $self->{see_also}) {
+    if (!exists $self->{see_also}) {
         my $ids = Bugzilla->dbh->selectcol_arrayref(
             'SELECT id FROM bug_see_also WHERE bug_id = ?',
             undef, $self->id);