From: Alan T. DeKok <aland@freeradius.org>
Date: Sat, 14 Feb 2026 13:19:46 +0000 (-0500)
Subject: don't close already closed socket
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4db6003e5f65947ff6605cfc75a6ee8a68ca796a;p=thirdparty%2Ffreeradius-server.git

don't close already closed socket
---

diff --git a/src/lib/util/inet.c b/src/lib/util/inet.c
index dea8fbabf77..d967b575e07 100644
--- a/src/lib/util/inet.c
+++ b/src/lib/util/inet.c
@@ -1185,13 +1185,13 @@ int fr_ipaddr_from_ifname(fr_ipaddr_t *out, int af, char const *name)
 	fd = socket(AF_INET, SOCK_DGRAM, 0);
 	if (fd < 0) {
 		fr_strerror_printf("Failed opening temporary socket for SIOCGIFADDR: %s", fr_syserror(errno));
-	error:
-		close(fd);
 		return -1;
 	}
 	if (ioctl(fd, SIOCGIFADDR, &if_req) < 0) {
 		fr_strerror_printf("Failed determining address for interface %s: %s", name, fr_syserror(errno));
-		goto error;
+	error:
+		close(fd);
+		return -1;
 	}
 
 	/*