From: Samasth Norway Ananda Date: Mon, 5 Jan 2026 20:38:33 +0000 (-0800) Subject: cxl/pci: Remove outdated FIXME comment and BUILD_BUG_ON X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4dd05f02f1d618da610e7d3bd479c47a96b4fc3f;p=thirdparty%2Fkernel%2Flinux.git cxl/pci: Remove outdated FIXME comment and BUILD_BUG_ON Remove the outdated FIXME comment about switching to struct_group() and the associated BUILD_BUG_ON check. This work was already completed in commit 301e68dd9b9b ("cxl/core: Replace unions with struct_group()") which converted struct cxl_regs to use struct_group_tagged(). The BUILD_BUG_ON was checking that anonymous union layout was preserved, but since struct_group() now handles this correctly, the compile-time check is no longer necessary. Signed-off-by: Samasth Norway Ananda Reviewed-by: Jonathan Cameron Reviewed-by: Dave Jiang Link: https://patch.msgid.link/20260105203833.1604585-1-samasth.norway.ananda@oracle.com Signed-off-by: Dave Jiang --- diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c index 0be4e508affe7..3b2293dffb3f7 100644 --- a/drivers/cxl/pci.c +++ b/drivers/cxl/pci.c @@ -912,13 +912,6 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) unsigned int i; bool irq_avail; - /* - * Double check the anonymous union trickery in struct cxl_regs - * FIXME switch to struct_group() - */ - BUILD_BUG_ON(offsetof(struct cxl_regs, memdev) != - offsetof(struct cxl_regs, device_regs.memdev)); - rc = pcim_enable_device(pdev); if (rc) return rc;