From: Michael Tremer Date: Mon, 27 Jan 2025 16:02:37 +0000 (+0000) Subject: python: Remove setters from Package X-Git-Tag: 0.9.30~349 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4de6abeb8b613884661ab85fdedb96fb38957ac7;p=pakfire.git python: Remove setters from Package We don't need to modify anything, we just want to read this all. Signed-off-by: Michael Tremer --- diff --git a/src/python/package.c b/src/python/package.c index 36f8ad8b..3813cc3e 100644 --- a/src/python/package.c +++ b/src/python/package.c @@ -189,12 +189,6 @@ static PyObject* Package_get_uuid(PackageObject* self) { return PyUnicode_FromString(uuid); } -static void Package_set_uuid(PackageObject* self, PyObject* value) { - const char* uuid = PyUnicode_FromValue(value); - - pakfire_package_set_string(self->package, PAKFIRE_PKG_UUID, uuid); -} - static PyObject* Package_get_digest(PackageObject* self) { enum pakfire_digest_types type = PAKFIRE_DIGEST_UNDEFINED; const unsigned char* digest = NULL; @@ -216,12 +210,6 @@ static PyObject* Package_get_summary(PackageObject* self) { return PyUnicode_FromString(summary); } -static void Package_set_summary(PackageObject* self, PyObject* value) { - const char* summary = PyUnicode_FromValue(value); - - pakfire_package_set_string(self->package, PAKFIRE_PKG_SUMMARY, summary); -} - static PyObject* Package_get_description(PackageObject* self) { const char* description = pakfire_package_get_string(self->package, PAKFIRE_PKG_DESCRIPTION); if (!description) @@ -230,12 +218,6 @@ static PyObject* Package_get_description(PackageObject* self) { return PyUnicode_FromString(description); } -static void Package_set_description(PackageObject* self, PyObject* value) { - const char* description = PyUnicode_FromValue(value); - - pakfire_package_set_string(self->package, PAKFIRE_PKG_DESCRIPTION, description); -} - static PyObject* Package_get_license(PackageObject* self) { const char* license = pakfire_package_get_string(self->package, PAKFIRE_PKG_LICENSE); if (!license) @@ -244,12 +226,6 @@ static PyObject* Package_get_license(PackageObject* self) { return PyUnicode_FromString(license); } -static void Package_set_license(PackageObject* self, PyObject* value) { - const char* license = PyUnicode_FromValue(value); - - pakfire_package_set_string(self->package, PAKFIRE_PKG_LICENSE, license); -} - static PyObject* Package_get_url(PackageObject* self) { const char* url = pakfire_package_get_string(self->package, PAKFIRE_PKG_URL); if (!url) @@ -258,12 +234,6 @@ static PyObject* Package_get_url(PackageObject* self) { return PyUnicode_FromString(url); } -static void Package_set_url(PackageObject* self, PyObject* value) { - const char* url = PyUnicode_FromValue(value); - - pakfire_package_set_string(self->package, PAKFIRE_PKG_URL, url); -} - static PyObject* Package_get_groups(PackageObject* self) { char** groups = pakfire_package_get_strings(self->package, PAKFIRE_PKG_GROUPS); @@ -280,15 +250,6 @@ static PyObject* Package_get_groups(PackageObject* self) { return ret; } -static int Package_set_groups(PackageObject* self, PyObject* value) { - const char* groups = PyUnicode_AsUTF8(value); - - if (groups) - pakfire_package_set_string(self->package, PAKFIRE_PKG_GROUPS, groups); - - return 0; -} - static PyObject* Package_get_vendor(PackageObject* self) { const char* vendor = pakfire_package_get_string(self->package, PAKFIRE_PKG_VENDOR); if (!vendor) @@ -297,12 +258,6 @@ static PyObject* Package_get_vendor(PackageObject* self) { return PyUnicode_FromString(vendor); } -static void Package_set_vendor(PackageObject* self, PyObject* value) { - const char* vendor = PyUnicode_FromValue(value); - - pakfire_package_set_string(self->package, PAKFIRE_PKG_VENDOR, vendor); -} - static PyObject* Package_get_distribution(PackageObject* self) { const char* distribution = pakfire_package_get_string(self->package, PAKFIRE_PKG_DISTRO); if (!distribution) @@ -311,12 +266,6 @@ static PyObject* Package_get_distribution(PackageObject* self) { return PyUnicode_FromString(distribution); } -static void Package_set_distribution(PackageObject* self, PyObject* value) { - const char* distribution = PyUnicode_AsUTF8(value); - - pakfire_package_set_string(self->package, PAKFIRE_PKG_DISTRO, distribution); -} - static PyObject* Package_get_packager(PackageObject* self) { const char* packager = pakfire_package_get_string(self->package, PAKFIRE_PKG_PACKAGER); if (!packager) @@ -325,13 +274,6 @@ static PyObject* Package_get_packager(PackageObject* self) { return PyUnicode_FromString(packager); } -static void Package_set_packager(PackageObject* self, PyObject* value) { - const char* packager = PyUnicode_FromValue(value); - - if (packager) - pakfire_package_set_string(self->package, PAKFIRE_PKG_PACKAGER, packager); -} - static PyObject* Package_get_filename(PackageObject* self) { const char* filename = pakfire_package_get_string(self->package, PAKFIRE_PKG_FILENAME); if (!filename) @@ -340,36 +282,18 @@ static PyObject* Package_get_filename(PackageObject* self) { return PyUnicode_FromString(filename); } -static void Package_set_filename(PackageObject* self, PyObject* value) { - const char* filename = PyUnicode_FromValue(value); - - pakfire_package_set_string(self->package, PAKFIRE_PKG_FILENAME, filename); -} - static PyObject* Package_get_downloadsize(PackageObject* self) { unsigned long long size = pakfire_package_get_num(self->package, PAKFIRE_PKG_DOWNLOADSIZE, 0); return PyLong_FromUnsignedLongLong(size); } -static void Package_set_downloadsize(PackageObject* self, PyObject* value) { - unsigned long long downloadsize = PyLong_AsUnsignedLong(value); - - pakfire_package_set_num(self->package, PAKFIRE_PKG_DOWNLOADSIZE, downloadsize); -} - static PyObject* Package_get_installsize(PackageObject* self) { unsigned long long size = pakfire_package_get_num(self->package, PAKFIRE_PKG_INSTALLSIZE, 0); return PyLong_FromUnsignedLongLong(size); } -static void Package_set_installsize(PackageObject* self, PyObject* value) { - unsigned long long installsize = PyLong_AsUnsignedLong(value); - - pakfire_package_set_num(self->package, PAKFIRE_PKG_INSTALLSIZE, installsize); -} - static PyObject* Package_get_size(PackageObject* self) { size_t size = pakfire_package_get_size(self->package); @@ -410,24 +334,12 @@ static PyObject* Package_get_buildhost(PackageObject* self) { return PyUnicode_FromString(build_host); } -static void Package_set_buildhost(PackageObject* self, PyObject* value) { - const char* build_host = PyUnicode_FromValue(value); - - pakfire_package_set_string(self->package, PAKFIRE_PKG_BUILD_HOST, build_host); -} - static PyObject* Package_get_buildtime(PackageObject* self) { time_t build_time = pakfire_package_get_num(self->package, PAKFIRE_PKG_BUILD_TIME, 0); return PyLong_FromUnsignedLongLong(build_time); } -static void Package_set_buildtime(PackageObject* self, PyObject* value) { - time_t build_time = PyLong_AsUnsignedLongLong(value); - - pakfire_package_set_num(self->package, PAKFIRE_PKG_BUILD_TIME, build_time); -} - static PyObject* Package_get_repo(PackageObject* self) { struct pakfire_repo* repo = pakfire_package_get_repo(self->package); if (!repo) @@ -611,77 +523,6 @@ static PyObject* Package_get_filelist(PackageObject* self, PyObject* args) { return list; } -static int Package_set_filelist(PackageObject* self, PyObject* value) { - if (!PySequence_Check(value)) { - PyErr_SetString(PyExc_AttributeError, "Expected a sequence."); - return -1; - } - - struct pakfire* pakfire = pakfire_package_get_pakfire(self->package); - - // Create a new filelist - struct pakfire_filelist* filelist; - - int r = pakfire_filelist_create(&filelist, pakfire); - if (r) { - pakfire_unref(pakfire); - errno = -r; - PyErr_SetFromErrno(PyExc_OSError); - - return -1; - } - - const int length = PySequence_Length(value); - for (int i = 0; i < length; i++) { - PyObject* item = PySequence_GetItem(value, i); - - if (!PyUnicode_Check(item)) { - Py_DECREF(item); - pakfire_filelist_unref(filelist); - pakfire_unref(pakfire); - - PyErr_SetString(PyExc_AttributeError, "Expected a string"); - return -1; - } - - const char* path = PyUnicode_AsUTF8(item); - Py_DECREF(item); - - // Create a new file - struct pakfire_file* file; - - r = pakfire_file_create(&file, pakfire, path); - if (r) { - errno = -r; - PyErr_SetFromErrno(PyExc_OSError); - pakfire_filelist_unref(filelist); - pakfire_unref(pakfire); - return -1; - } - - // Append the file to the filelist - pakfire_filelist_add(filelist, file); - pakfire_file_unref(file); - } - - // Set filelist - r = pakfire_package_set_filelist(self->package, filelist); - pakfire_filelist_unref(filelist); - - if (r) { - pakfire_unref(pakfire); - - errno = -r; - PyErr_SetFromErrno(PyExc_OSError); - - return -1; - } - - pakfire_unref(pakfire); - - return 0; -} - static PyObject* Package_dump(PackageObject* self, PyObject *args, PyObject* kwds) { const char* kwlist[] = { "long", "filelist", NULL }; @@ -724,15 +565,6 @@ static PyObject* Package_get_source_name(PackageObject* self) { return PyUnicode_FromString(source_name); } -static PyObject* Package_set_source_name(PackageObject* self, PyObject* value) { - const char* source_name = PyUnicode_AsUTF8(value); - if (!source_name) - return NULL; - - pakfire_package_set_string(self->package, PAKFIRE_PKG_SOURCE_NAME, source_name); - Py_RETURN_NONE; -} - static PyObject* Package_get_source_evr(PackageObject* self) { const char* source_evr = pakfire_package_get_string(self->package, PAKFIRE_PKG_SOURCE_EVR); if (!source_evr) @@ -741,15 +573,6 @@ static PyObject* Package_get_source_evr(PackageObject* self) { return PyUnicode_FromString(source_evr); } -static PyObject* Package_set_source_evr(PackageObject* self, PyObject* value) { - const char* source_evr = PyUnicode_AsUTF8(value); - if (!source_evr) - return NULL; - - pakfire_package_set_string(self->package, PAKFIRE_PKG_SOURCE_EVR, source_evr); - Py_RETURN_NONE; -} - static PyObject* Package_get_source_arch(PackageObject* self) { const char* source_arch = pakfire_package_get_string(self->package, PAKFIRE_PKG_SOURCE_ARCH); if (!source_arch) @@ -758,15 +581,6 @@ static PyObject* Package_get_source_arch(PackageObject* self) { return PyUnicode_FromString(source_arch); } -static PyObject* Package_set_source_arch(PackageObject* self, PyObject* value) { - const char* source_arch = PyUnicode_AsUTF8(value); - if (!source_arch) - return NULL; - - pakfire_package_set_string(self->package, PAKFIRE_PKG_SOURCE_ARCH, source_arch); - Py_RETURN_NONE; -} - static PyObject* Package_installcheck(PackageObject* self) { char* problem = NULL; int r; @@ -832,7 +646,7 @@ static struct PyGetSetDef Package_getsetters[] = { { "uuid", (getter)Package_get_uuid, - (setter)Package_set_uuid, + NULL, NULL, NULL }, @@ -846,77 +660,77 @@ static struct PyGetSetDef Package_getsetters[] = { { "summary", (getter)Package_get_summary, - (setter)Package_set_summary, + NULL, NULL, NULL }, { "description", (getter)Package_get_description, - (setter)Package_set_description, + NULL, NULL, NULL }, { "license", (getter)Package_get_license, - (setter)Package_set_license, + NULL, NULL, NULL }, { "url", (getter)Package_get_url, - (setter)Package_set_url, + NULL, NULL, NULL }, { "groups", (getter)Package_get_groups, - (setter)Package_set_groups, + NULL, NULL, NULL }, { "vendor", (getter)Package_get_vendor, - (setter)Package_set_vendor, + NULL, NULL, NULL }, { "distribution", (getter)Package_get_distribution, - (setter)Package_set_distribution, + NULL, NULL, NULL }, { "packager", (getter)Package_get_packager, - (setter)Package_set_packager, + NULL, NULL, NULL }, { "filename", (getter)Package_get_filename, - (setter)Package_set_filename, + NULL, NULL, NULL }, { "downloadsize", (getter)Package_get_downloadsize, - (setter)Package_set_downloadsize, + NULL, NULL, NULL }, { "installsize", (getter)Package_get_installsize, - (setter)Package_set_installsize, + NULL, NULL, NULL }, @@ -937,14 +751,14 @@ static struct PyGetSetDef Package_getsetters[] = { { "buildhost", (getter)Package_get_buildhost, - (setter)Package_set_buildhost, + NULL, NULL, NULL }, { "buildtime", (getter)Package_get_buildtime, - (setter)Package_set_buildtime, + NULL, NULL, NULL }, @@ -965,21 +779,21 @@ static struct PyGetSetDef Package_getsetters[] = { { "source_name", (getter)Package_get_source_name, - (setter)Package_set_source_name, + NULL, NULL, NULL }, { "source_evr", (getter)Package_get_source_evr, - (setter)Package_set_source_evr, + NULL, NULL, NULL }, { "source_arch", (getter)Package_get_source_arch, - (setter)Package_set_source_arch, + NULL, NULL, NULL }, @@ -1055,7 +869,7 @@ static struct PyGetSetDef Package_getsetters[] = { { "filelist", (getter)Package_get_filelist, - (setter)Package_set_filelist, + NULL, NULL, NULL },