From: Tomek Mrugalski <tomasz@isc.org>
Date: Thu, 18 Jul 2019 11:34:01 +0000 (+0200)
Subject: [#644,!370] Manual apply of ce489f0e3ace53ca9ba937579a55458ecc4d878f
X-Git-Tag: Kea-1.6.1~10^2~69
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4df3185b71f7bb83207b20cbe44738a8508cb23b;p=thirdparty%2Fkea.git

[#644,!370] Manual apply of ce489f0e3ace53ca9ba937579a55458ecc4d878f
---

diff --git a/doc/sphinx/arm/hooks-lease-cmds.rst b/doc/sphinx/arm/hooks-lease-cmds.rst
index d329755e08..58e956b5d5 100644
--- a/doc/sphinx/arm/hooks-lease-cmds.rst
+++ b/doc/sphinx/arm/hooks-lease-cmds.rst
@@ -36,6 +36,9 @@ This library provides the following commands:
 
 -  ``lease6-add`` - adds a new IPv6 lease.
 
+-  ``lease6-bulk-apply`` - creates, updates and/or deletes multiple
+   IPv6 leases in a single transaction.
+
 -  ``lease4-get`` - checks whether an IPv4 lease with the specified
    parameters exists and returns it if it does.
 
@@ -242,6 +245,112 @@ Example failure:
 
    { "result": 1, "text": "missing parameter 'ip-address' (<string>:3:19)" }
 
+
+.. _command-lease6-bulk-apply:
+
+The lease6-bulk-apply Command
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The ``lease6-bulk-apply`` was implemented to address
+the performance penalty in the High Availability when a single DHCPv6
+transaction resulted in multiple lease updates sent to the partner if
+multiple address and/or prefix leases were allocated. Consider the case
+when a DHCPv6 client requests the assignment of two IPv6 addresses and two IPv6
+prefixes. That may result in allocation of 4 leases. In addition, the
+DHCPv6 may assign different address than requested by the client during
+the renew or rebind and delete the leases previously used by this client.
+The are 6 of lease changes sent between the HA partners is in this case.
+Sending these updates in individual commands, e.g. ``lease6-update``
+is highly inefficient and produces unnecessary delays in communication
+between the HA partners and in sending the response to the DHCPv6 client.
+
+The ``lease6-bulk-apply`` command deals with this
+problem by aggregating all lease changes in a single command. Both
+deleted leases and new/updated leases are conveyed in a single command.
+The receiving server iterates over the deleted leases and deletes them
+from its lease database. Next, it iterates over the new/updated leases
+and adds them to the database or updates them if they already exist.
+
+Even though the High Avialability is the major application for
+this command, it can be freely used in all cases when it is desired to
+send multiple lease changes in a single command.
+
+In the following example, we ask to delete two leases and to add
+or update two other leases in the database:
+
+
+::
+
+    {
+      "command": "lease6-bulk-apply",
+      "arguments": {
+          "deleted-leases": [
+              {
+                  "subnet-id": 66,
+                  "ip-address": "2001:db8:abcd::",
+                  "type": "IA_PD",
+                  ...
+              },
+              {
+                  "subnet-id": 66,
+                  "ip-address": "2001:db8:abcd::234",
+                  "type": "IA_NA",
+                  ...
+              }
+          ],
+          "leases": [
+              {
+                  "subnet-id": 66,
+                  "ip-address": "2001:db8:cafe::",
+                  "type": "IA_PD",
+                   ...
+              },
+              {
+                  "subnet-id": 66,
+                  "ip-address": "2001:db8:abcd::333",
+                  "type": "IA_NA",
+                  ...
+              }
+          ]
+       }
+   }
+
+If any of the leases is malformed, no leases changes are applied
+to the lease database. If the leases are well formed but there is a
+failure to apply any of the lease changes to the database, the command
+will continue to be processed for other leases. All the leases for which
+the command was unable to apply the changes in the database will be
+listed in the response. For example:
+
+::
+
+    {
+        "result": 0,
+        "text": "Bulk apply of 2 IPv6 leases completed".
+        "arguments": {
+            "failed-deleted-leases": [
+                {
+                    "subnet-id": 66,
+                    "ip-address": "2001:db8:abcd::",
+                    "type": "IA_PD"
+                }
+            ],
+            "failed-leases": [
+                {
+                    "subnet-id": 66,
+                    "ip-address": "2001:db8:cafe::",
+                    "type": "IA_PD",
+                    ...
+                }
+            ]
+        }
+    }
+
+The response above indicates that the hooks library was unable to
+delete the lease for prefix "2001:db8:abcd::" and add or update the lease
+for prefix "2001:db8:cafe::". However, there are two other lease changes
+which have been applied as indicated by the text message.
+
 .. _command-lease4-get:
 
 The lease4-get, lease6-get Commands