From: Sami Kerola <kerolasa@iki.fi>
Date: Mon, 15 Aug 2016 20:23:28 +0000 (+0100)
Subject: warnings: do not take abs() when data type is unsigned
X-Git-Tag: v0.88~38^2~1^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4e37ddfe64e4957e54528bf10a43ee3ce59d8f4d;p=thirdparty%2Fmtr.git

warnings: do not take abs() when data type is unsigned

Taking the absolute value of unsigned type 'unsigned int' has no effect.
---

diff --git a/net.c b/net.c
index fa5b3ef..47b0c9b 100644
--- a/net.c
+++ b/net.c
@@ -256,7 +256,7 @@ int udp_checksum(void *pheader, void *udata, int psize, int dsize, int alt_check
 {
   unsigned int tsize = psize + dsize;
   char csumpacket[tsize];
-  memset(csumpacket, (unsigned char) abs(bitpattern), abs(tsize));
+  memset(csumpacket, (unsigned char) abs(bitpattern), tsize);
   if (alt_checksum && dsize >= 2) {
     csumpacket[psize + sizeof(struct UDPHeader)] = 0;
     csumpacket[psize + sizeof(struct UDPHeader) + 1] = 0;