From: John Ferlan Date: Thu, 7 Jun 2018 00:21:26 +0000 (-0400) Subject: qemu: Allow no address to be defined for virtio-scsi iothread attach X-Git-Tag: v4.5.0-rc1~164 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4e3a9daa6668051f1d8669e989ae7594c4e22619;p=thirdparty%2Flibvirt.git qemu: Allow no address to be defined for virtio-scsi iothread attach https://bugzilla.redhat.com/show_bug.cgi?id=1583623 When attaching a virtio-scsi with IOThreads for the config of a live domain, allow the
to not be defined thus allowing post parse processing to fill in the address. This allows parsing of an individual device to succeed for attach config. Signed-off-by: John Ferlan Reviewed-by: Ján Tomko --- diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index cd8870ae1f..ac37fe1212 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4781,7 +4781,8 @@ qemuDomainCheckSCSIControllerIOThreads(const virDomainControllerDef *controller, if (!controller->iothread) return true; - if (controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && + if (controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE && + controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("virtio-scsi IOThreads only available for virtio "