From: Jeremy Allison <jra@samba.org>
Date: Tue, 28 Jan 2020 00:45:20 +0000 (-0800)
Subject: s3: smbd: dfs: Allow parse_msdfs_symlink() to be called with NULL pointers.
X-Git-Tag: ldb-2.1.1~59
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4e4afc52e6f63fa4058310c6b0a0314b8f73c189;p=thirdparty%2Fsamba.git

s3: smbd: dfs: Allow parse_msdfs_symlink() to be called with NULL pointers.

In case we don't want all the data.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c
index 2d784430ebf..4df881bd87e 100644
--- a/source3/smbd/msdfs.c
+++ b/source3/smbd/msdfs.c
@@ -565,14 +565,14 @@ bool parse_msdfs_symlink(TALLOC_CTX *ctx,
 	DBG_DEBUG("count=%zu\n", count);
 
 	if (count) {
-		reflist = *preflist = talloc_zero_array(ctx,
+		reflist = talloc_zero_array(ctx,
 				struct referral, count);
 		if(reflist == NULL) {
 			TALLOC_FREE(alt_path);
 			return false;
 		}
 	} else {
-		reflist = *preflist = NULL;
+		reflist = NULL;
 	}
 
 	for(i=0;i<count;i++) {
@@ -601,8 +601,12 @@ bool parse_msdfs_symlink(TALLOC_CTX *ctx,
 			reflist[i].alternate_path);
 	}
 
-	*refcount = count;
-
+	if (preflist != NULL) {
+		*preflist = reflist;
+	}
+	if (refcount != NULL) {
+		*refcount = count;
+	}
 	TALLOC_FREE(alt_path);
 	return true;
 }