From: Reed Loden <reed@reedloden.com>
Date: Tue, 6 Apr 2010 03:21:50 +0000 (-0500)
Subject: Bug 532350 - "Can't add Debian bug URLs to a bug using "See Also""
X-Git-Tag: bugzilla-3.6~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4e4c2ca1443c8547307e41fc37e36a591d2acb8d;p=thirdparty%2Fbugzilla.git

Bug 532350 - "Can't add Debian bug URLs to a bug using "See Also""
[r=LpSolit r=mkanat a=mkanat]
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 5696880fa1..6114b0ae44 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -2421,6 +2421,27 @@ sub add_see_also {
         $result = "http://code.google.com/p/" . $project_name .
                   "/issues/detail?id=" . $bug_id;
     }
+    # Debian BTS URLs
+    elsif ($uri->authority =~ /^bugs.debian.org$/i) {
+        # Debian BTS URLs can look like various things:
+        #   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1234
+        #   http://bugs.debian.org/1234
+        my $bug_id;
+        if ($uri->path =~ m|^/(\d+)$|) {
+            $bug_id = $1;
+        }
+        elsif ($uri->path =~ /bugreport\.cgi$/) {
+            $bug_id = $uri->query_param('bug');
+            detaint_natural($bug_id);
+        }
+        if (!$bug_id) {
+            ThrowUserError('bug_url_invalid',
+                           { url => $input, reason => 'id' });
+        }
+        # This is the shortest standard URL form for Debian BTS URLs,
+        # and so we reduce all URLs to this.
+        $result = "http://bugs.debian.org/" . $bug_id;
+    }
     # Bugzilla URLs
     else {
         if ($uri->path !~ /show_bug\.cgi$/) {