From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 4 Aug 2021 09:13:10 +0000 (+0200)
Subject: virSecuritySELinuxContextListAppend: Remove unreachable cleanup
X-Git-Tag: v7.7.0-rc1~275
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4e7576a74168b3a0614bdf0463ea879455ac307d;p=thirdparty%2Flibvirt.git

virSecuritySELinuxContextListAppend: Remove unreachable cleanup

'item' is always NULLed-out by VIR_APPEND_ELEMENT and 'ret' variable is
always 0 when used so both can be removed.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index 30fb6028aa..9ff35a7be5 100644
--- a/src/security/security_selinux.c
+++ b/src/security/security_selinux.c
@@ -114,7 +114,6 @@ virSecuritySELinuxContextListAppend(virSecuritySELinuxContextList *list,
                                     bool remember,
                                     bool restore)
 {
-    int ret = -1;
     virSecuritySELinuxContextItem *item = NULL;
 
     item = g_new0(virSecuritySELinuxContextItem, 1);
@@ -127,9 +126,7 @@ virSecuritySELinuxContextListAppend(virSecuritySELinuxContextList *list,
 
     VIR_APPEND_ELEMENT(list->items, list->nItems, item);
 
-    ret = 0;
-    virSecuritySELinuxContextItemFree(item);
-    return ret;
+    return 0;
 }
 
 static void