From: Luca Ceresoli Date: Thu, 23 Apr 2026 09:17:26 +0000 (+0200) Subject: drm/msm/mdp4: remove now-redundant call to drm_connector_attach_encoder() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4e833e078f3d40d4f4a24c162210a1b7855f1539;p=thirdparty%2Fkernel%2Flinux.git drm/msm/mdp4: remove now-redundant call to drm_connector_attach_encoder() drm_connector_attach_encoder() is now called by drm_bridge_connector_init(). Reviewed-by: Dmitry Baryshkov Acked-by: Dmitry Baryshkov Link: https://patch.msgid.link/20260423-drm-bridge-connector-attach_encoder-v2-32-2ae6ca69b390@bootlin.com Signed-off-by: Luca Ceresoli --- diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c index 809ca191e9de7..7726edb0d4ede 100644 --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c @@ -232,13 +232,6 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms, return PTR_ERR(connector); } - ret = drm_connector_attach_encoder(connector, encoder); - if (ret) { - DRM_DEV_ERROR(dev->dev, "failed to attach LVDS connector: %d\n", ret); - - return ret; - } - break; case DRM_MODE_ENCODER_TMDS: encoder = mdp4_dtv_encoder_init(dev);