From: Mike Yuan <me@yhndnzj.com>
Date: Thu, 30 May 2024 12:54:24 +0000 (+0800)
Subject: core/dbus-unit: use UNIT_IS_LOAD_ERROR where appropriate
X-Git-Tag: v257-rc1~888^2~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4e8b11ca16a94c2fd6e49e1585a941bb968031dc;p=thirdparty%2Fsystemd.git

core/dbus-unit: use UNIT_IS_LOAD_ERROR where appropriate
---

diff --git a/src/core/dbus-unit.c b/src/core/dbus-unit.c
index 707644d2f90..0161a1bf458 100644
--- a/src/core/dbus-unit.c
+++ b/src/core/dbus-unit.c
@@ -1807,9 +1807,7 @@ int bus_unit_queue_job_one(
                         type = JOB_TRY_RELOAD;
         }
 
-        if (type == JOB_STOP &&
-            IN_SET(u->load_state, UNIT_NOT_FOUND, UNIT_ERROR, UNIT_BAD_SETTING) &&
-            unit_active_state(u) == UNIT_INACTIVE)
+        if (type == JOB_STOP && UNIT_IS_LOAD_ERROR(u->load_state) && unit_active_state(u) == UNIT_INACTIVE)
                 return sd_bus_error_setf(error, BUS_ERROR_NO_SUCH_UNIT, "Unit %s not loaded.", u->id);
 
         if ((type == JOB_START && u->refuse_manual_start) ||