From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 19 Oct 2023 03:22:28 +0000 (+1300)
Subject: tests/krb5: Remove unnecessary target_creds variables
X-Git-Tag: talloc-2.4.2~1204
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4e8fb9706e226fe4f44140c1df64c155c36f22f7;p=thirdparty%2Fsamba.git

tests/krb5: Remove unnecessary target_creds variables

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/tests/krb5/conditional_ace_tests.py b/python/samba/tests/krb5/conditional_ace_tests.py
index c478dfe00a8..d54931724d1 100755
--- a/python/samba/tests/krb5/conditional_ace_tests.py
+++ b/python/samba/tests/krb5/conditional_ace_tests.py
@@ -2924,11 +2924,9 @@ class DeviceRestrictionTests(ConditionalAceBaseTests):
         client_creds = self._get_creds(account_type=self.AccountType.USER,
                                        assigned_policy=client_policy)
 
-        target_creds = self.get_krbtgt_creds()
-
         # Show that authentication fails.
         self._armored_as_req(client_creds,
-                             target_creds,
+                             self.get_krbtgt_creds(),
                              mach_tgt,
                              expected_error=KDC_ERR_POLICY)
 
@@ -2980,11 +2978,9 @@ class DeviceRestrictionTests(ConditionalAceBaseTests):
         client_creds = self._get_creds(account_type=self.AccountType.USER,
                                        assigned_policy=client_policy)
 
-        target_creds = self.get_krbtgt_creds()
-
         # Show that authentication succeeds.
         self._armored_as_req(client_creds,
-                             target_creds,
+                             self.get_krbtgt_creds(),
                              mach_tgt)
 
         self.check_as_log(client_creds,
@@ -3031,11 +3027,9 @@ class DeviceRestrictionTests(ConditionalAceBaseTests):
         client_creds = self._get_creds(account_type=self.AccountType.USER,
                                        assigned_policy=client_policy)
 
-        target_creds = self.get_krbtgt_creds()
-
         # Show that authentication fails.
         self._armored_as_req(client_creds,
-                             target_creds,
+                             self.get_krbtgt_creds(),
                              mach_tgt,
                              expected_error=KDC_ERR_POLICY)
 
@@ -3216,11 +3210,9 @@ class DeviceRestrictionTests(ConditionalAceBaseTests):
         client_creds = self._get_creds(account_type=self.AccountType.USER,
                                        assigned_policy=client_policy)
 
-        target_creds = self.get_krbtgt_creds()
-
         # Show that authentication fails.
         self._armored_as_req(client_creds,
-                             target_creds,
+                             self.get_krbtgt_creds(),
                              mach_tgt,
                              expected_error=KDC_ERR_POLICY)
 
@@ -3315,11 +3307,9 @@ class DeviceRestrictionTests(ConditionalAceBaseTests):
         client_creds = self._get_creds(account_type=self.AccountType.USER,
                                        assigned_policy=client_policy)
 
-        target_creds = self.get_krbtgt_creds()
-
         # Show that authentication fails.
         self._armored_as_req(client_creds,
-                             target_creds,
+                             self.get_krbtgt_creds(),
                              mach_tgt,
                              expected_error=KDC_ERR_POLICY)
 
@@ -3370,11 +3360,9 @@ class DeviceRestrictionTests(ConditionalAceBaseTests):
         client_creds = self._get_creds(account_type=self.AccountType.USER,
                                        assigned_policy=client_policy)
 
-        target_creds = self.get_krbtgt_creds()
-
         # Show that authentication succeeds.
         self._armored_as_req(client_creds,
-                             target_creds,
+                             self.get_krbtgt_creds(),
                              mach_tgt)
 
         self.check_as_log(client_creds,
@@ -3426,11 +3414,9 @@ class DeviceRestrictionTests(ConditionalAceBaseTests):
         client_creds = self._get_creds(account_type=self.AccountType.USER,
                                        assigned_policy=client_policy)
 
-        target_creds = self.get_krbtgt_creds()
-
         # Show that authentication fails.
         self._armored_as_req(client_creds,
-                             target_creds,
+                             self.get_krbtgt_creds(),
                              mach_tgt,
                              expected_error=KDC_ERR_POLICY)