From: James Jones <jejones3141@gmail.com>
Date: Tue, 30 May 2023 20:06:07 +0000 (-0500)
Subject: Pull check for non-NULL randle after check for NULL randle
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4e9bfdaad296e1a5131fead21862dba4e674e95b;p=thirdparty%2Ffreeradius-server.git

Pull check for non-NULL randle after check for NULL randle

randle is local to mod_authenticate(), so in the then clause
of an if checking for randle being NULL, randle won't be non-NULL.
---

diff --git a/src/modules/rlm_imap/rlm_imap.c b/src/modules/rlm_imap/rlm_imap.c
index 93b4c4a4201..23c28918d6c 100644
--- a/src/modules/rlm_imap/rlm_imap.c
+++ b/src/modules/rlm_imap/rlm_imap.c
@@ -177,7 +177,6 @@ static unlang_action_t CC_HINT(nonnull(1,2)) mod_authenticate(rlm_rcode_t *p_res
 
 	randle = imap_slab_reserve(t->slab);
 	if (!randle){
-		if (randle) imap_slab_release(randle);
 		RETURN_MODULE_FAIL;
 	}